Skip to content

test_logsafe: placeholders a sibling's privacy scan accepts - #33

Merged
SDNick484 merged 1 commit into
mainfrom
audit/privacy-scan-placeholders
Nov 10, 2026
Merged

SDNick484 merged 1 commit into
mainfrom
audit/privacy-scan-placeholders

Conversation

@SDNick484

Copy link
Copy Markdown
Owner

Summary

Found during B (the sibling sync to 9449e9f / v0.1.0). mcp-server-steam-backlog's CI runs .github/scripts/privacy_scan.py, and its sync failed test_the_scanner_passes_on_this_repository on two values #28 added to templates/tests/test_logsafe.py:

Line Was Why the scan flags it Now
207 first.last+tag@mail.example.co.uk only example.com/.org/.net, .test, .invalid count as placeholder mail domains first.last+tag@mail.example.org
292 (comment) ::ffff:0.0.0.1 0.0.0.1 isn't loopback, RFC 5737 or RFC 1918 ::ffff:127.0.0.1

Test data and a comment only: no module changes, so no sibling behaviour change. The e-mail case still covers a +tag local part on a multi-label domain.

The other eight siblings' sync PRs passed their checks because they don't run this scan. Only steam-backlog does.

Breaking: no. Consumers affected: all 10 (rendered tests/test_logsafe.py only).

Test plan

  • steam-backlog's privacy_scan.py --no-history over this repo: 2 findings before, none after
  • render + ruff check (incl. --no-respect-gitignore tests) + ruff format --check + mypy + pytest: 356 passed

🤖 Generated with Claude Code

mcp-server-steam-backlog's CI runs a privacy scan over its files, and
its sync to 9449e9f failed on two values in the rendered
test_logsafe.py: mail.example.co.uk (only example.com/.org/.net, .test
and .invalid count as placeholders) and the 0.0.0.1 in a comment's
::ffff:0.0.0.1 (only loopback, documentation and RFC 1918 IPv4 do).
Swap them for mail.example.org and ::ffff:127.0.0.1; both tests still
cover what they did.

Refs #16

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant