Repository navigation
test_logsafe: placeholders a sibling's privacy scan accepts - #33
Merged
Merged
Conversation
mcp-server-steam-backlog's CI runs a privacy scan over its files, and its sync to 9449e9f failed on two values in the rendered test_logsafe.py: mail.example.co.uk (only example.com/.org/.net, .test and .invalid count as placeholders) and the 0.0.0.1 in a comment's ::ffff:0.0.0.1 (only loopback, documentation and RFC 1918 IPv4 do). Swap them for mail.example.org and ::ffff:127.0.0.1; both tests still cover what they did. Refs #16 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found during B (the sibling sync to
9449e9f/ v0.1.0). mcp-server-steam-backlog's CI runs.github/scripts/privacy_scan.py, and its sync failedtest_the_scanner_passes_on_this_repositoryon two values #28 added totemplates/tests/test_logsafe.py:first.last+tag@mail.example.co.ukexample.com/.org/.net,.test,.invalidcount as placeholder mail domainsfirst.last+tag@mail.example.org::ffff:0.0.0.10.0.0.1isn't loopback, RFC 5737 or RFC 1918::ffff:127.0.0.1Test data and a comment only: no module changes, so no sibling behaviour change. The e-mail case still covers a
+taglocal part on a multi-label domain.The other eight siblings' sync PRs passed their checks because they don't run this scan. Only steam-backlog does.
Breaking: no. Consumers affected: all 10 (rendered
tests/test_logsafe.pyonly).Test plan
privacy_scan.py --no-historyover this repo: 2 findings before, none afterruff check(incl.--no-respect-gitignore tests) +ruff format --check+mypy+pytest: 356 passed🤖 Generated with Claude Code