Repository navigation
Shutdown grace (initd retry) and CI hardening - #20
Merged
Merged
Conversation
supervise-daemon's default stop schedule is SIGTERM/5: SIGKILL five seconds after SIGTERM. That covers this server's usual shutdown but leaves no margin for a slow one, and SIGKILL skips the lifespan teardown. The comment above the setting in its initd gives the worst case. supervise-daemon takes the schedule when the service starts, so the restart that installs the file still stops on the old one. Refs SDNick484/mcp-server-shared#16 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dabot - permissions: contents: read for the whole workflow (jobs only read the checkout) - concurrency: one run per branch and event; only PR runs cancel, so a push to main can't cancel the weekly --latest drift check - timeout-minutes on every job: 15 for test/alpine/docker/build (about 2 minutes today), 10 for the rest - every action pinned to the commit its tag pointed at, version as a comment, so a moved tag can't change what runs - release.yml: the same pins and timeouts (it already had permissions) - .github/dependabot.yml: github-actions and pip, weekly on Monday, grouped The shared-drift job moves to mcp-server-shared's reusable workflow in a follow-up commit, once that repo tags v0.1.0. Refs SDNick484/mcp-server-shared#16 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Closing and reopening to trigger CI: the first push started no workflow run. |
The inline job becomes `uses: SDNick484/mcp-server-shared/.github/ workflows/shared-drift.yml@<SHA> # v0.1.0`. Same checks on the same events: --check always, --check --latest on schedule and workflow_dispatch, still run with this repo's own sync_shared.py. The workflow, its action pins, timeout and concurrency now live in one place instead of being copied here. The ref is pinned to the commit v0.1.0 points at, with the tag as a comment, so Dependabot's github-actions updates bump it like an action. Refs SDNick484/mcp-server-shared#16 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The workflow file is the same at v0.1.0 and v0.1.1; this only moves the pin to the tag the shared files are synced to, so Dependabot doesn't open a bump for it straight away. Refs SDNick484/mcp-server-shared#16 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the mcp-server-shared audit (SDNick484/mcp-server-shared#16), items C1 and C2. Three parts:
1. initd:
retry="SIGTERM/15/SIGKILL/5". supervise-daemon's default stop schedule isSIGTERM/5. Thisserver's shutdown: at most about 7 s (2 s drain, then hubs disconnect in parallel, 5 s cap each).
2. CI hardening
permissions: contents: readfor the whole workflow.github/dependabot.yml:github-actionsandpip, weekly on Monday, grouped (one PR each)release.yml: the same SHA pins and timeouts (it already hadpermissions)concurrency: one run per branch and event; onlypull_requestruns cancel, so a push tomaincan'tcancel the weekly scheduled
--check --latesttimeout-minuteson every job: 15 for test/alpine/docker/build (about 2 min today), 10 for the restbehaviour change)
3.
shared-driftcalls mcp-server-shared's reusable workflow (SDNick484/mcp-server-shared#30) instead of carrying its own copy:uses: SDNick484/mcp-server-shared/.github/workflows/shared-drift.yml@5f9b824… # v0.1.1. Same checks on the same events (--checkalways,--check --lateston schedule and manual runs), still run with this repo's ownsync_shared.py. Dependabot'sgithub-actionsupdates bump the pin like any action.Deploy
supervise-daemon reads
retrywhen the service starts (it's passed as--retryat start and stored), sothe restart that installs the file still stops on the old 5 s schedule; every stop after uses the new one.
CI changes need no deploy step.
Test plan
timeout-minutes@v7,@v8,@release/v1) resolves to todayretryhandling checked against OpenRC'ssupervise-daemon.sh/supervise-daemon.crc-service <svc> restarttwice; the second stop logs no SIGKILL🤖 Generated with Claude Code