Various fixes#333
Open
jacobmerson wants to merge 5 commits into
Open
Conversation
jacobmerson
force-pushed
the
various-fixes
branch
from
af00254 to
b5c8994
Compare
…ordinateView::GetCoordinates -> GetValues Squashed original commits: 7986df9, c063a3a
The issue was that we were storing the uniform grid by reference. However, GPU needs to deep_copy the grid.
We fix the layouts in a few places to handle fields with multiple components.
…always has classification Squashed original commits: d7daece, bb57d62
jacobmerson
force-pushed
the
various-fixes
branch
from
b5c8994 to
b4d81b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is layered on top of #332