Fix contig_n50 column assigned contig_l50 values in filter_by_genome_quality#33
Open
dingyifei wants to merge 1 commit into
Open
Fix contig_n50 column assigned contig_l50 values in filter_by_genome_quality#33dingyifei wants to merge 1 commit into
dingyifei wants to merge 1 commit into
Conversation
…quality Line 101 was typecasting contig_l50 (instead of contig_n50) into the contig_n50 column, silently replacing N50 values with L50 values for all downstream filtering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jtburrows
approved these changes
Jun 4, 2026
jtburrows
left a comment
jtburrows
left a comment
Contributor
There was a problem hiding this comment.
Good catch on the inconsistency; the change is appropriate and fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 101 was typecasting contig_l50 (instead of contig_n50) into the contig_n50 column, silently replacing N50 values with L50 values for all downstream filtering.