Skip to content

Adding the Tag Property to ServiceInstance - #350

Open
d068sap wants to merge 4 commits into
mainfrom
feat/service-instance-tags
Open

d068sap wants to merge 4 commits into
mainfrom
feat/service-instance-tags

Conversation

@d068sap

@d068sap d068sap commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Observe and reconcile Service Instance tags

Adds full support for the tags field on ServiceInstance resources, for both managed and user-provided instances. Tags are now applied on create, reconciled on update, and observed back from CloudFoundry so drift is detected.

Tag behavior

  • Omitting the field equals an empty list. A nil/absent tags field and tags: []are treated identically — both mean "no tags." An absent field will not leave existing tags untouched; it reconciles the instance to having no tags.
  • Order-independent. Tags are compared as sets, so [prod, eu-central] and [eu-central, prod] are considered equal and do not cause updates/drift.

@Kukkerem Kukkerem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread internal/clients/serviceinstance/serviceinstance.go Outdated
Comment thread internal/clients/serviceinstance/serviceinstance.go Outdated

@Kukkerem Kukkerem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@Kukkerem
Kukkerem enabled auto-merge (squash) October 5, 2026 16:01

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants