Github Action to Build and Publish Releases - #435
Conversation
KarstenSchnitter
left a comment
KarstenSchnitter
left a comment
There was a problem hiding this comment.
Thank you for providing this PR. I have a suggestion on the private key passphrase and some minor formulation question.
- Doc wording - GPG passphrase support
KarstenSchnitter
left a comment
KarstenSchnitter
left a comment
There was a problem hiding this comment.
Thanks for the effort. Looks good to me. Happy testing.
|
@Felix-Griesau-SAP congratulations to your first merge. |
| - name: Set up JDK, Maven settings, GPG | ||
| uses: actions/setup-java@cf277c60eb25467037889841efdb72551f06f6c3 # v4.9.1 | ||
| with: | ||
| distribution: temurin |
There was a problem hiding this comment.
@KarstenSchnitter technically it makes no difference, but I would favor a sapmachine here . FYI @Felix-Griesau-SAP
There was a problem hiding this comment.
So far I have built the releases using a SAPMachine. I support the recommendation.
There was a problem hiding this comment.
I'll open another PR for that.
I based the choice on the existing configuration in the other workflow though. I'll change that as well then:
3 participants
This PR adds a github workflow to build and publish releases.
It will be triggered automatically upon creating a github release, or independently on demand. I added a little md file explaining some details, that should also help reproducing the setup if it ever breaks.
As of now, I haven't created the proper credentials yet. As already discussed, my plan is to first test-run this (after merge) without valid credentials to see if everything is behaving as expected, and then testing with valid credentials.