fix: [DevOps] Fix e2e-test set up - #1048
Merged
Merged
Conversation
vladimir-a-sap
approved these changes
Sep 15, 2026
vladimir-a-sap
left a comment
vladimir-a-sap
left a comment
Contributor
There was a problem hiding this comment.
- acceptable as a temporary fix to be reverted after we stop supporting v1
- a potentially cleaner and less brittle solution proposed in the comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes a problem introduced in the most recent e2e test change. The problem is that
matrix.branchis not available at job level but only on steps level. This led to github not parsing the yaml file.I pulled the if into the steps level. It is less concise but works. Happy for other options.
Successful run here.