Skip to content

feat: replace inheritance with composition for orch config and prompt clients - #1043

Open
vladimir-a-sap wants to merge 1 commit into
v2from
aggregate-instead-inherit-in-client-classes
Open

vladimir-a-sap wants to merge 1 commit into
v2from
aggregate-instead-inherit-in-client-classes

Conversation

@vladimir-a-sap

@vladimir-a-sap vladimir-a-sap commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Context

[AI SDK v2] Don't directly extend low-level classes for hand-written SERVICEClient classes

  • Replaced inheritance with composition for OrchestrationConfigClient and PromptClient
  • Added simple tests

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Relevant E2E tests are green (at least locally)
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK (not applicable)
  • Documentation updated (apparently not applicable)
  • Release notes updated (apparently not applicable)

@vladimir-a-sap
vladimir-a-sap marked this pull request as ready for review September 10, 2026 15:32
@vladimir-a-sap
vladimir-a-sap enabled auto-merge (squash) September 10, 2026 15:35
@vladimir-a-sap vladimir-a-sap changed the title feat: replace inheritance with aggregation for orch config and prompt clients feat: replace inheritance with cpmposition for orch config and prompt clients Sep 11, 2026
@vladimir-a-sap vladimir-a-sap changed the title feat: replace inheritance with cpmposition for orch config and prompt clients feat: replace inheritance with composition for orch config and prompt clients Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant