Clarify that server-ca is optional for mTLS ingest - #61
Open
JannikBrand wants to merge 1 commit into
Open
JannikBrand wants to merge 1 commit into
JannikBrand wants to merge 1 commit into
Conversation
Signed-off-by: Jannik Brand <jannik.brand@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clarify that the
server-cavalue returned in service bindings is optional for mTLS ingest into SAP Cloud Logging.The ingest endpoints (
ingest-mtls,ingest-otlp) present a server certificate that chains to a public root (Let's Encrypt ISRG Root X1). Any runtime whose system trust store already carries the public roots — which is the default for CF stacks, SapMachine, current Node.js versions — needs no additional pinning. Instructing consumers to pinserver-caas a sole trust anchor was misleading and became actively wrong when the ingestion CA was rotated (a customer whose app pinned the previous intermediate saw ingest break).Changes
server-cafrom the user-provided-service (cf cups) example and itsjqextractor. Loggregator's HTTPS writer adds a UPS-suppliedcaadditively to the platform's trust pool; it is not required when the endpoint chains to a public root.--cacert server-ca.crtfrom thecurlexample (call it out as optional in a note).server-cain the sample credentials JSON as optional and add a clarifying note. Also relaxed the wording "the required endpoint and credentials" → "the endpoint and credentials".Context
Companion changes in the two SAP-provided OTel helper libraries follow up:
Both currently reject a service binding without
server-cain theirvalidate(), and, for the ones that accept it, pin it as sole anchor instead of appending it. Those PRs make the field optional and treat it additively.