Repository navigation
Presentation-only two-decimal comparison Markdown (SAM_UI#238 companion) - #15
Merged
Merged
Conversation
Adds a presentation-only formatter for the Markdown report. CSV and summary JSON keep the raw full-precision contract; no tolerance, gate, engine or calculation changes.
Records tested content 7fd54b3 and the presentation-only scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged and closed out - 2026-10-17
Merged into
sow/2026-Q4as912ae94ef68af20b437fc92ec7e8891fd1cb640f, using a merge commit guarded to owner-approved head4a7da6b1821d303d183fe87d275b5d0aaf05460e. No automatic merge or administrative bypass. Owner authorization came from the explicit gated merge instruction; no GitHub approval review was fabricated.Final-head Build 39068752757 and SPDX 39068752748 passed. Post-merge Build 39070909651 and manually dispatched SPDX 39071240235 passed at the immutable merge SHA. Hosted comparator 100/100 and public-API 2/2, zero skipped. Dependency logs: SAM / SAM_Mollier
sow/2026-Q4, SAM_IAPWS default branch.Closeout:
68eded0060047af714853a02a152fb9c960bfeb1, docs-onlyPROJECT_PROGRESS.mdon Q4 with[skip ci]. Fully merged task branchclaude/tas-openstudio-comparisonwas deleted remotely with an expected-SHA lease and locally withbranch -dafter all cleanup guards passed; worktrees/frozen quarters preserved. Primary checkout is clean Q4. This removes dependency-branch shadowing for downstream UI checks.No local test suite/build or real simulation was rerun during merge/closeout. Post-merge tests executed in CI; saved reports/hashes and existing acceptance artifacts were independently inspected. Numerical engine disagreement, HungaryHouse Tas crash, unavailable input manifests and producer deployment remain unresolved. UI#237/#238 are held for missing G1 evidence/explicit deferrals and approval of their documentation-corrected pins. Earlier implementation record follows; this merge status supersedes its not-merged wording.
Presentation-only two-decimal comparison Markdown
Status: implemented; not merged. Companion to SAM_UI#238. Follow-up to merged SAM_Validation#14.
sow/2026-Q4at8fa79f5c8559c2db11e0ce2a26193e5ccad80e79a39e4a9fd11019de9400f62fe5e68179539a4661claude/tas-openstudio-comparisonat4a7da6b(record-only commit after the tested content)Scope
Presentation only.
comparison.csvandcomparison-summary.jsonkeep their schema, columns and full precision;Format.Number/Format.Percentremain the raw contract. No simulation, conversion, metric mapping, unit conversion, tolerance, gate or comparison arithmetic changed.What changed
PresentationFormat: two-decimal engineering values, absolute differences and percentages; hour-of-year values and hour differences stay integers; null/NaN/infinity rendern/aand are never zero; informational labelInformational - excluded from numerical status; unit mismatch remains distinct; space name/GUID and input-manifest helpers.ComparisonResultadds contributing/informational Fail counts using the comparator's existing classification. The saved example is 10 Fail (4 contributing, 6 informational); overall/numerical Fail, coverage Warn, provenance/reconciliation Pass are unchanged.n/a/-markers,designDaySource=None, the input-manifest limitation and engine warnings/notes. Reconciliation uses two decimals and adds a normalized difference column; space metrics show the space name beside its GUID.WriteMarkdown.AppendToleranceProfilecastHourWarnAbsolute/HourFailAbsolutetoint, so a valid profile with 1.5 h / 24.5 h was reported as 1 h / 24 h. It now renders both withFormat.Number, exactly ascomparison.csvdoes. Integer formatting remains where it belongs: hour-of-year indices and hour differences. The default profile still renders 1 h / 24 h, so the goldens are unchanged.Validation
dotnet test SAM.Analytical.Benchmark.Compare.Tests -c Releasedotnet test SAM.Analytical.Benchmark.Compare.ApiTests -c ReleaseSAM_Validation.slnRelease rebuildbox-bothdocumentsThe new regression
ReportTests.MarkdownKeepsFractionalHourThresholdsAndAgreesWithTheRawProfileasserts the Markdown contains 1.5 h / 24.5 h (and not 1 h / 24 h), that the summary JSON'stoleranceProfileDetail.hourWarnAbsolute/hourFailAbsoluteequal the raw profile, and that every CSV row carries1.5,24.5.Saved comparison invariants: 6 Match / 0 Warn / 10 Fail / 2 N/A; 4 Fail rows contribute to the numerical status and 6 are informational. Overall/Numerical Fail, Coverage Warn, Provenance/Reconciliation Pass are unchanged. Regenerated
comparison.csvSHA-2568092B384DD9D9BA9289E1C10B77DB7C93BCD95E911B4A0F32CEE93373C0ECD3Dandcomparison-summary.jsonSHA-25636B9D353B35CDFEB1FBAC70B78317BF36C4F393159F114FCF39716D825FF4A98are byte-identical to the saved run.Gaps / follow-up
Hosted CI passed at final head
4a7da6b: Build (Windows) run 39068752757 succeeded, includingTest benchmark comparator (dotnet test); SPDX run 39068752748 succeeded. The additional local suite and build results are listed above.Next step
Merge this presentation PR before SAM_UI#238 so the UI and Markdown use the same helpers, then rerun #238 CI. Do not merge automatically.