Repository navigation
style(ui): simulation dialog consistency with Part O - #246
Merged
Merged
Conversation
…O styling XAML-only: merge PartOStyles, Roboto Light, Part O margins, caption/heading styles, primary button and 28 px button row. Adds SAM_UI dialog conventions and a validation policy to AGENTS.md (CLAUDE.md imports it). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
michaldengusiak
marked this pull request as ready for review
October 20, 2026 12:28
michaldengusiak
added a commit
that referenced
this pull request
Oct 20, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunSimulationWindowandEngineComparisonWindow(S01-S06 simulation dialogs) now follow the Part O look: mergePartOStyles.xaml, Roboto Light, 16/14 margins,PartO.SectionHeading/Caption,PartO.PrimaryButtonfor Run / Run Tas + OpenStudio, 28 px buttons, surface/border banner.AGENTS.md: SAM_UI dialog conventions (Part O as reference) and the validation policy.CLAUDE.mdalready importsAGENTS.md, so nothing is duplicated.Simulation behaviour unchanged
Only two
.xamlfiles andAGENTS.mdchanged. No.cs, no element names, handlers, cancellation, diagnostics or result logic. Part O windows untouched. Data-grid band/row colours in the comparison window were left as they are (they carry text labels too).Validation (local)
dotnet build WPF/SAM.Analytical.UI.WPF -c Release: 0 errors (existing warnings only), isolated worktree output.EngineComparisonWindow,SimulationConcurrencyGuard, RunSimulation tests: 10/10 pass.Not in scope / reported
MessageBoxes and the banner in code-behind; moving them to the shared progress window is a larger change (separate PR).EngineComparisonWindow.xaml.csare still literal RGB.Draft: do not merge until S06 is merged and integration conflicts are checked. Note the
docs/agent-instructions-rollout-q4worktree may also touchAGENTS.md.🤖 Generated with Claude Code
Final visual and runtime acceptance (2026-10-20)
Method: temporary uncommitted test harness instantiated the real windows from the worktree build (fabricated comparison documents, no simulation, installed app untouched). Screenshots:
documentation/evidence/sim-dialog-consistency/(README lists them).PartOStyles.xamlloads at runtime in both windows: no missing-resource exceptions.sow/2026-Q4has no new commits;git merge-treeagainst it is clean, incl.AGENTS.md.Limitations: 150% is rendered at 1.5 scale, not a real Windows 150% display session; Roboto Light is absent here (fallback font, same as Part O reference); title bar/ownership/resize-grip behaviour not captured by the renders (ResizeMode/Owner unchanged from before except as listed).
Recommendation: PASS for visual/runtime acceptance; stays draft until S06 merges.