Repository navigation
docs: licensed Tas/OpenStudio end-to-end validation and discrepancy diagnosis - #239
Merged
michaldengusiak merged 6 commits intoOct 19, 2026
Merged
Conversation
…iagnosis Fresh licensed Run Simulation > Both runs from the real SAM Analytical UI (isolated Q4 build): box-aperture with embedded weather and with the source Budapest EPW, and HungaryHouse (Tas crash not reproduced). Reports reproduced byte-for-byte by benchmark-compare; values and arithmetic checked independently against TSD/TBD/ESO output. Diagnosis: the embedded-weather EPW export has GHI=0 and horizontal direct in the DNI column (Tas runs without solar); outdoor-air ventilation reaches EnergyPlus but not Tas; OpenStudio cooling is total vs Tas sensible; Tas space peak hour is 1-based and space peaks are design-day governed. No time offset between engines. No product change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…anel hypothesis (SAM_UI#239) Tas-only controlled experiment: baseline re-run reproduces the original TSD bit-for-bit; closing only GF_08's window (shared aperture type isolated) cuts GF_08 heating 1425.6 -> 387.6 kWh and whole-building heating 4507.4 -> 3388.9 kWh. Evidence and tools under window-opening/. No product, test, tolerance or baseline change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ouse (SAM_UI#239) Tas-only: detaching all window aperture types cuts heating 4507.4 -> 3190.5 kWh (-1317.0, 47.8% of the 2756 kWh gap; 1439.3 kWh remains vs E+). Adds aperture inventory, baseline aperture behaviour, three-scenario comparison, Part O audit and a window-control architecture assessment. Fixes the earlier dump tool's zone index (LivingRoom was omitted). No product, test, tolerance or baseline change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ds reconciliation (SAM_UI#239) GF_08 WindandStackOpenArea + EMS ramp/Part O latch verified in native outputs; unlimited Ideal Loads run away, capacity-limited variants compared with Tas (flow character, heating, temperature). 44.6 kWh difference resolved as the heating design day in an earlier per-zone summary. Corrects C7 per-zone E+ values. Authored-vs-default audit of the Part O settings. No product change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Pre-F1 embedded-weather evidence superseded by SAM#212; C6-C8 and engine-physics work frozen (Phase C); findings mapped to roadmap tasks (SAM#213). All licensed-run evidence kept unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michaldengusiak
added a commit
that referenced
this pull request
Oct 19, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only. Record:
documentation/Licensed-TasOpenStudio-Validation-Q4.md; evidence:documentation/evidence/licensed-e2e-20261019/. Validated content: Q44ee45fef(SAM_UI),68eded0(SAM_Validation),618db819(SAM),a34a298d(SAM_Tas),d4216f3(SAM_OpenStudio). No product, test, tolerance, physics or baseline change.Results (fresh licensed runs, real SAM Analytical UI, Run Simulation > Both)
Reports are byte-identical to
benchmark-compare.exe; values and differences are independently rechecked against TSD/TBD/ESO output. There is no time offset between the engines.Main findings (details and proposed fixes in the record)
SAM.Weather.Query.DataString) writes global horizontal and horizontal IR as 0, and horizontal direct into the DNI column. With embedded weather, Tas simulates without solar gain.SAM_UI\buildhas a staledeps.jsonfrom the pre-Simulate > OpenStudio Simulation: minimal OpenStudio/EnergyPlus run from SAM_UI (#229) #237 baseline build, so Both/OpenStudio cannot load there. A Rebuild is needed. This is not a product defect.Unresolved: the box cooling residual (~20%) after aligning ventilation, and the remaining HungaryHouse heating gap (whole-house temperature and internal gains; see F8/C6).
0a569236): HungaryHouse GF_08 heating is mostly Tas window opening (zdwnoPart O aperture function, not converted by SAM_OpenStudio). Tas-only experiment: baseline re-run reproduces the original TSD bit-for-bit; closing only GF_08's window gives GF_08 1425.6 → 387.6 kWh and whole-building 4507.4 → 3388.9 kWh (−1118.5 kWh, 40.6% of the 2756 kWh gap). TheAir-panel hypothesis is refuted for the bathrooms.Checks:
git diff --checkclean; docs/evidence only (4 analysis.cstools with SPDX headers, not part of any project). Full runs are machine-local underC:\TasOut\licensed-e2e-20261019.Not for merge without owner review.
zdwno,0,22,24,99string on all 9 windows; GF_08's ramp starts below its 24 °C setpoint; string has one field fewer than EDSL documents;Unrestrictednight opening is a loader default. Recommended milestone:ZoneVentilation:WindandStackOpenArea+ EMS (design only, nothing implemented).🤖 Generated with Claude Code