Repository navigation
Sync master with HoareLea/SAM_Template master (post 2026-Q3 merge) - #9
Merged
Merged
Conversation
…-windows) (HoareLea#13) SAM.Analytical.Grasshopper.TMP was the last net472/Rhino 7 project in this repo. Matches the net8.0-windows/Rhino 8 shape used by every other Grasshopper project in the workspace: - TargetFramework net472 -> net8.0-windows - Rhino7*InstallDir/PluginsDir registry vars -> Rhino*InstallDir/PluginsDir, pointed at Rhinoceros\8.0 / 8.0-WIP-Developer-Debug-trunk - Grasshopper PackageReference 6.32.20340.21001 -> 8.21.25188.17001 - StartProgram Rhino 6 -> Rhino 8 Verified with dotnet build -t:Rebuild: succeeds, 0 errors (the NU1701 warning about com.angusj.Clipper targeting an older framework is pre-existing and also present on already-migrated Grasshopper projects; unrelated to this change). Generated by Michal Dengusiak and CodeClaude Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* chore: drop Rhino <8 support in Grasshopper project (net472 -> net8.0-windows) SAM.Analytical.Grasshopper.TMP was the last net472/Rhino 7 project in this repo. Matches the net8.0-windows/Rhino 8 shape used by every other Grasshopper project in the workspace: - TargetFramework net472 -> net8.0-windows - Rhino7*InstallDir/PluginsDir registry vars -> Rhino*InstallDir/PluginsDir, pointed at Rhinoceros\8.0 / 8.0-WIP-Developer-Debug-trunk - Grasshopper PackageReference 6.32.20340.21001 -> 8.21.25188.17001 - StartProgram Rhino 6 -> Rhino 8 Verified with dotnet build -t:Rebuild: succeeds, 0 errors (the NU1701 warning about com.angusj.Clipper targeting an older framework is pre-existing and also present on already-migrated Grasshopper projects; unrelated to this change). Generated by Michal Dengusiak and CodeClaude Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Add AI agent instructions and project progress tracking * build: remove dead .NET Framework app.config leftovers 2 app.config files were net472-era leftovers containing assembly binding redirects and <supportedRuntime sku=".NETFramework,Version=v4.8"/>, neither of which has any effect under .NET 8. Every project here targets net8.0-windows or netstandard2.0 and is OutputType Library, and a library's .dll.config is never read at runtime (only the host .exe.config is). Their only remaining effect was to emit stale SAM.*.dll.config files into build/ and the %APPDATA%\SAM deploy folder. Verified: no TargetFramework other than net8.0-windows/netstandard2.0 in any csproj; every project is OutputType Library (no Exe/WinExe); no ConfigurationManager/System.Configuration/AppSettings/OpenExeConfiguration usage in any .cs file; each deleted app.config contained only assemblyBinding/dependentAssembly/assemblyIdentity/bindingRedirect/runtime/ startup/supportedRuntime elements; no csproj/props/yml references app.config/AppConfig/dll.config, and the PostBuild Exec targets copy only *.dll/*.gha. Compile-only (-t:Compile, not a full build) verification of both affected projects: 0 errors each (SAM.Analytical.Grasshopper.TMP had 2 pre-existing, unrelated NU1701 warnings about the com.angusj.Clipper package targeting .NET Framework). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * docs: record merged .NET Framework app.config cleanup in PROJECT_PROGRESS Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: remove internal agent/progress files and evidence artifacts from upstream contribution Removes AGENTS.md, PROJECT_PROGRESS.md and internal evidence/.claude artefacts that are SAM-BIM workflow records, not upstream project documentation. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ZiolkowskiJakub
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-only sync of SAM-BIM/master to HoareLea/master 3e77839 (2026-Q3 upstream merge). Branch tip equals HoareLea master exactly; no internal working files (AGENTS.md / PROJECT_PROGRESS.md) included. Intended merge method: merge commit (keeps the HoareLea commit as an ancestor).