Repository navigation
build: remove dead .NET Framework app.config leftovers - #7
Merged
michaldengusiak merged 1 commit intoSep 22, 2026
Merged
Conversation
2 app.config files were net472-era leftovers containing assembly binding redirects and <supportedRuntime sku=".NETFramework,Version=v4.8"/>, neither of which has any effect under .NET 8. Every project here targets net8.0-windows or netstandard2.0 and is OutputType Library, and a library's .dll.config is never read at runtime (only the host .exe.config is). Their only remaining effect was to emit stale SAM.*.dll.config files into build/ and the %APPDATA%\SAM deploy folder. Verified: no TargetFramework other than net8.0-windows/netstandard2.0 in any csproj; every project is OutputType Library (no Exe/WinExe); no ConfigurationManager/System.Configuration/AppSettings/OpenExeConfiguration usage in any .cs file; each deleted app.config contained only assemblyBinding/dependentAssembly/assemblyIdentity/bindingRedirect/runtime/ startup/supportedRuntime elements; no csproj/props/yml references app.config/AppConfig/dll.config, and the PostBuild Exec targets copy only *.dll/*.gha. Compile-only (-t:Compile, not a full build) verification of both affected projects: 0 errors each (SAM.Analytical.Grasshopper.TMP had 2 pre-existing, unrelated NU1701 warnings about the com.angusj.Clipper package targeting .NET Framework). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 2 net472-era
app.configfiles that are dead weight under .NET 8:Grasshopper/SAM.Analytical.Grasshopper.TMP/app.configSAM_TMP/SAM.Analytical.TMP/app.configBoth contained only
<runtime><assemblyBinding>binding redirects (one also had<supportedRuntime sku=".NETFramework,Version=v4.8"/>), which.NET 8ignores entirely —bindingRedirectis a Fusion/.NET-Framework-only mechanism. Every project here isOutputType Librarytargetingnet8.0-windowsornetstandard2.0, and a library'sX.dll.configis never read by the CLR at runtime (only the host process's.exe.configis — Rhino.exe/Grasshopper here, untouched). Their only effect was staleSAM.*.dll.configfiles landing inbuild/and%APPDATA%\SAM.Verification (gates re-run in this repo, not assumed from the template)
TargetFrameworkin any.csproj(onlynet8.0-windows/netstandard2.0).OutputType Library(noExe/WinExe).ConfigurationManager/System.Configuration/AppSettings/OpenExeConfigurationusage anywhere in.csfiles.app.configcontained onlyassemblyBinding/dependentAssembly/assemblyIdentity/bindingRedirect/runtime/startup/supportedRuntimeelements — read and checked individually..csproj/.props/.ymlreferencesapp.config/AppConfig/dll.config;PostBuildExectargets copy only*.dll/*.gha.Test plan
dotnet build -t:Compile, not a full build, to avoid triggering the GrasshopperPostBuildtarget that rewrites%APPDATA%\SAM) for both affected projects: 0 errors each.SAM.Analytical.Grasshopper.TMP: 0 errors, 2 pre-existing unrelatedNU1701warnings (com.angusj.Clipperpackage targeting .NET Framework).SAM.Analytical.TMP: 0 errors, 0 warnings.buildcheck on this PR🤖 Generated with Claude Code