Repository navigation
chore: drop Rhino <8 support in Grasshopper project (net472 -> net8.0-windows) - #6
Merged
Merged
Conversation
…-windows) SAM.Analytical.Grasshopper.TMP was the last net472/Rhino 7 project in this repo. Matches the net8.0-windows/Rhino 8 shape used by every other Grasshopper project in the workspace: - TargetFramework net472 -> net8.0-windows - Rhino7*InstallDir/PluginsDir registry vars -> Rhino*InstallDir/PluginsDir, pointed at Rhinoceros\8.0 / 8.0-WIP-Developer-Debug-trunk - Grasshopper PackageReference 6.32.20340.21001 -> 8.21.25188.17001 - StartProgram Rhino 6 -> Rhino 8 Verified with dotnet build -t:Rebuild: succeeds, 0 errors (the NU1701 warning about com.angusj.Clipper targeting an older framework is pre-existing and also present on already-migrated Grasshopper projects; unrelated to this change). Generated by Michal Dengusiak and CodeClaude Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SAM.Analytical.Grasshopper.TMP was the last net472/Rhino 7 project in this repo. Matches the net8.0-windows/Rhino 8 shape used everywhere else: TargetFramework net472 -> net8.0-windows, Rhino7* registry vars -> Rhino* pointed at 8.0/8.0-WIP, Grasshopper package 6.32.20340.21001 -> 8.21.25188.17001, StartProgram Rhino 6 -> Rhino 8.
Test plan
dotnet build -t:Rebuild: succeeds, 0 errors (the NU1701 warning aboutcom.angusj.Clippertargeting an older framework is pre-existing and also present on already-migrated Grasshopper projects; unrelated to this change)Generated by Michal Dengusiak and CodeClaude