Repository navigation
SAM GH icon redesign: apply SAM icon design system to SAM_Systems (38/38) [Q4 migration of #32] - #37
Merged
Conversation
… Grasshopper objects Propagates the SAM Grasshopper icon redesign (SAM-BIM/SAM#166) to SAM_Systems: - design/grasshopper-icons: shared SAM-BIM icon kit (icons.py/render.py/ sam_classify.py vendored verbatim from SAM#166 @ cf4d924a, hash-checked; SAM-BIM extension glyphs v1; repo_rules.py), manifest (source of truth), SVG sources, 24x24 PNGs, contact sheet, Rhino 8 icon load test. - 38/38 objects wired through the existing resx/Bitmap mechanism; only the icon token in each Icon getter changes. No GUID/API/behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit bad9d31)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 5822f5e)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit ca0cc8d)
…ph; no icon change here) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 028cca0)
… or source change) Brings tools/ and tests/GhIconTest in line with the other SAM-BIM repos: inventory honours <Compile Remove>, check_source accepts multi-line Icon getters, check_assemblies skips obj/ reference assemblies, integrate matches public Designer visibility, harness gains the offline assembly mode. Re-running the inventory here gives an identical result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 0a15f74)
…anged by the icon PR The spdx-check workflow requires the LGPL-3.0-or-later SPDX line and the copyright line in every changed .cs file. Adds the standard header to the 10 pre-existing files touched by the icon-token swaps (and to the kit's IconTests.cs). No other change. check_source.py now accepts exactly this header as the only non-icon addition and diffs against the merge base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 4c32610)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Point the PR record at the replacement Q4 PR and base, keep the old Q3 PR referenced for provenance, and note the Q4 re-validation. Documentation only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icon migration validation — 2026-10-11
Base:
sow/2026-Q4. Scope: SAM-BIM only. Reference: SAM#179; SAM#166 is the closed historical design source.Changes and decisions
Fresh validation
Next step: verify final-head GitHub checks and merge only if green and safe under the owner authorization. No force-push or branch deletion. Hosted Rhino smoke is tracked separately; prior historical results are not fresh runs.