Repository navigation
SAM GH icon redesign: apply SAM icon design system to SAM_Multitasker (9/9) - #8
Closed
SAM-BIM-AI wants to merge 4 commits into
Closed
SAM-BIM-AI wants to merge 4 commits into
SAM-BIM-AI wants to merge 4 commits into
Conversation
…ker Grasshopper objects Propagates the SAM Grasshopper icon redesign (SAM-BIM/SAM#166) to SAM_Multitasker: - design/grasshopper-icons: shared SAM-BIM icon kit (icons.py/render.py/ sam_classify.py vendored verbatim from SAM#166 @ cf4d924a, hash-checked; SAM-BIM extension glyphs v1; repo_rules.py), manifest (source of truth), SVG sources, 24x24 PNGs, contact sheet, Rhino 8 icon load test. - 9/9 objects wired through the project's existing icon mechanism; only the icon token in each Icon getter changes. No GUID/API/behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SAM-BIM-AI
requested review from
ZiolkowskiJakub and
michaldengusiak
as code owners
September 28, 2026 16:50
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…anged by the icon PR The spdx-check workflow requires the LGPL-3.0-or-later SPDX line and the copyright line in every changed .cs file. Adds the standard header to the 10 pre-existing files touched by the icon-token swaps (and to the kit's IconTests.cs). No other change. check_source.py now accepts exactly this header as the only non-icon addition and diffs against the merge base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Superseded by the validated Q4 migration in #10. The original icon-redesign commits were replayed onto |
michaldengusiak
added a commit
that referenced
this pull request
Oct 11, 2026
SAM GH icon redesign: apply SAM icon design system to SAM_Multitasker (9/9) [Q4 migration of #8]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagates the SAM Grasshopper icon design system (SAM-BIM/SAM#166, kept open) to SAM_Multitasker: 9/9 GH objects (5 components + 4 params), 9 distinct 24×24 icons.
icons.py/render.py/sam_classify.pyvendored verbatim from SAM#166 @cf4d924a(hash-checked).result,settings,value.script,tasks; new verbrun.design/grasshopper-icons/manifest.json|csv) is the source of truth; review sheetdesign/grasshopper-icons/review/contact_sheet.png.Icongetter changes. No API, GUID, name, category, input/output or behaviour change.Validation
tools/classify.pytools/build.pyidentical-pixel collision checkreview/REVIEW.md)png/24tools/integrate.pyre-parseSAM_GH_*resource; every PNG existstools/check_source.pyvsorigin/sow/2026-Q3dotnet build SAM_Multitasker.sln -c Debugtools/check_assemblies.pytests/GhIconTest(real Rhino 8 / Grasshopper, Rhino.Testing)review/contact_sheet.png, 24 px on normal / warning / dark bodies)Record:
docs/GH-IconRedesign.md. Do not merge until reviewed.🤖 Generated with Claude Code