Skip to content

SAM GH icon redesign: apply SAM icon design system to SAM_Multitasker (9/9) - #8

Closed
SAM-BIM-AI wants to merge 4 commits into
sow/2026-Q3from
feature/sam-gh-icon-redesign
Closed

SAM-BIM-AI wants to merge 4 commits into
sow/2026-Q3from
feature/sam-gh-icon-redesign

Conversation

@SAM-BIM-AI

Copy link
Copy Markdown

Summary

Propagates the SAM Grasshopper icon design system (SAM-BIM/SAM#166, kept open) to SAM_Multitasker: 9/9 GH objects (5 components + 4 params), 9 distinct 24×24 icons.

  • Same grammar (object glyph + SAM-green subject + operation badge), same SAM-BIM palette, same deterministic renderer: icons.py / render.py / sam_classify.py vendored verbatim from SAM#166 @ cf4d924a (hash-checked).
  • Reused SAM families: result, settings, value.
  • New families (SAM-BIM extension v1, shared by all SAM-BIM repos): script, tasks; new verb run.
  • Manifest (design/grasshopper-icons/manifest.json|csv) is the source of truth; review sheet design/grasshopper-icons/review/contact_sheet.png.
  • Only the icon token in each Icon getter changes. No API, GUID, name, category, input/output or behaviour change.

Validation

Check Result
tools/classify.py 9 classified, 0 unclassified
tools/build.py identical-pixel collision check 0 groups (9 distinct icons; 0 intentionally shared icon(s) for qualifier variants, listed in review/REVIEW.md)
Icon ids shared with SAM#166 vs SAM's png/24 3 shared, 3 byte-identical
tools/integrate.py re-parse 9/9 objects reference their SAM_GH_* resource; every PNG exists
tools/check_source.py vs origin/sow/2026-Q3 vendored files OK; icon-token swaps: 9, non-icon changes: 0; base 12, now 12 -> UNCHANGED
dotnet build SAM_Multitasker.sln -c Debug Build succeeded, 0 errors
tools/check_assemblies.py every assembly embeds every required 24×24 icon → OK
tests/GhIconTest (real Rhino 8 / Grasshopper, Rhino.Testing) 9/9 objects verified: 9 load in real Rhino 8 / Grasshopper by GUID (name/category match); icon = manifest PNG (max diff 1 level, premultiplied-alpha rounding)
Repository test projects none in this repository
Visual review (review/contact_sheet.png, 24 px on normal / warning / dark bodies) all icons legible; no collisions

Record: docs/GH-IconRedesign.md. Do not merge until reviewed.

🤖 Generated with Claude Code

SAM-BIM-AI and others added 2 commits September 28, 2026 18:50
…ker Grasshopper objects

Propagates the SAM Grasshopper icon redesign (SAM-BIM/SAM#166) to SAM_Multitasker:
- design/grasshopper-icons: shared SAM-BIM icon kit (icons.py/render.py/
  sam_classify.py vendored verbatim from SAM#166 @ cf4d924a, hash-checked;
  SAM-BIM extension glyphs v1; repo_rules.py), manifest (source of truth),
  SVG sources, 24x24 PNGs, contact sheet, Rhino 8 icon load test.
- 9/9 objects wired through the project's existing icon mechanism; only the
  icon token in each Icon getter changes. No GUID/API/behaviour change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SAM-BIM-AI and others added 2 commits September 28, 2026 18:50
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…anged by the icon PR

The spdx-check workflow requires the LGPL-3.0-or-later SPDX line and the
copyright line in every changed .cs file. Adds the standard header to the
10 pre-existing files touched by the icon-token swaps (and to the kit's
IconTests.cs). No other change. check_source.py now accepts exactly this
header as the only non-icon addition and diffs against the merge base.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michaldengusiak

Copy link
Copy Markdown

Superseded by the validated Q4 migration in #10. The original icon-redesign commits were replayed onto sow/2026-Q4 and verified for feature equivalence. This Q3 PR is being closed without merge; its historical branch (feature/sam-gh-icon-redesign) is being preserved.

michaldengusiak added a commit that referenced this pull request Oct 11, 2026
SAM GH icon redesign: apply SAM icon design system to SAM_Multitasker (9/9) [Q4 migration of #8]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants