Repository navigation
Fix Roslyn Diagnostic collision with SAM.Core diagnostics - #12
Merged
michaldengusiak merged 4 commits intoOct 15, 2026
Merged
Conversation
michaldengusiak
marked this pull request as ready for review
October 15, 2026 19:20
michaldengusiak
added a commit
that referenced
this pull request
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding SAM.Core.Diagnostic in SAM#201 changes unqualified Diagnostic resolution inside SAM.Core.Multitasker, so unchanged script compilation fails with CS0029. Use a distinct RoslynDiagnostic alias in both compilation and result types, preserving the historical public Roslyn APIs and all algorithms.
Proven cause
Validation
Tested content: cfe9d11. Final PR head: e245510; subsequent commits contain records only, final diff check passes.
Evidence: documentation/Diagnostic-Collision-Validation-2026-10-15.md and documentation/evidence/diagnostic-collision-2026-10-15/*.json record exact configurations, boundary, timing and retained local log hashes. Raw local logs and the archive harness are machine-local as labeled in the record.
Base sow/2026-Q4. No algorithm/component/workflow/shared SAM.Core changes. PROJECT_PROGRESS is unchanged under the post-merge-only policy. Owner authorized merging once green on 2026-10-15. Final-head checks and compilation logs verified before merge.