Repository navigation
fix(geometry): Triangle2D.Reverse reverses the stored vertex order (Q4) - #229
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review (marked 2026-11-01 09:15 UTC under
michaldengusiak). Pilot LOOP-1. Do not merge without the owner's exact approval line for the final head.This delivery does not close F2, the tamper promise, teardown, continuity, S-09 or Phase 1a.
Change
Triangle2D.Reverse()did nothing:points.Reverse();on aPoint2D[]binds to LINQ and the result was discarded. It is nowArray.Reverse(points);, the same fix SAM#228 made inTriangle3D. No signature, JSON or tolerance change.Face.Reverse()reaches this method throughIReversiblewhen an edge is aTriangle2D, so the earlier "no callers" record was incomplete. Such a face is built by the public implicitFace2D(Triangle2D)operator. Record:documentation/Triangle2D-Reverse-Q4.md.Heads
sow/2026-Q415d8c9097360ffd2580ef3b82239e70c3b646c94914be22451da79dcc9b0aedf0f02e70496781245Face2Dtest after the owner's PR review; production code unchanged)5d608857004b3ad30b6d2f9e6546af7f53999f0b2646daea74e7e22529e181cd7ecf4d938b909d2fLocal checks at
5d608857(developer run, Debug, outside MXC)dotnet test SAM/SAM.Tests/SAM.Tests.csproj -p:NuGetAudit=falseIReversibleandFace2Dtests fail on the unfixed source; the other 2 of 6 pass, as expected of a no-opLocal checks at
914be224(not repeated at5d608857)SAM.Tests.PartOBaselineReferenceTests.ARenamedDesign_IsFoundByIdentityandSAM.Tests.PartOBaselineReferenceTests.ARuntimeHint_FindsADesignTheLocatorCannot_AndIsNotPersisted, owner direction 29: they fail under MXC onFile.Moveaccess denied. Both passed in a separate local run outside MXCsamctl spdxgpt-6.1-solHighGitHub checks at the final head
spdx,build (Release)andtest (Release)passed at2646daea. Thetest (Release)job log reports 3981 total, 3981 passed, and has aPassedline for both excluded tests and all six new tests, with noFailedline.Not run:
SAM.Core.Grasshopper.Tests, which needs Rhino.Not covered: the internal-edge branch of
Face.Reverse()has no test.🤖 Generated with Claude Code