Repository navigation
Refactor tests and update mocks for discover UI - #226
Merged
Merged
Conversation
Improve and stabilize unit tests across the Discover UI: use concrete mock data for sections, switch several tests to await/waitFor for async behavior, and simplify rendering assertions for empty states. Update MadeForYouCard tests to use isMixLiked/toggleMix (and adjust expected payload and heart icon class checks). Adjust CuratedMixCard to expect a fallback image, remove flaky verified-badge assertions from artist/user card tests, and make TrackListSection assert the empty container renders. Add mocks for useAuthStore and PremiumPromoModal in DiscoverPageAuth tests and make RecentlyPlayed failure handling test assert it doesn't throw and that the API was called. Other test files updated to target mocked child components where applicable.
nourabosaif
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve and stabilize unit tests across the Discover UI