Repository navigation
Use curl -fsS for frontend smoke check - #219
Merged
Merged
Conversation
Replace the manual HTTP status check and conditional logic with a simpler `curl -fsS` invocation that exits non-zero on network or HTTP errors. This simplifies the workflow step, makes failures reliable, and keeps the job failing when the frontend is unreachable or returns an error. Also normalizes the URL with a trailing slash.
OmarHamza22
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the manual HTTP status check and conditional logic with a simpler
curl -fsSinvocation that exits non-zero on network or HTTP errors. This simplifies the workflow step, makes failures reliable, and keeps the job failing when the frontend is unreachable or returns an error. Also normalizes the URL with a trailing slash.