Skip to content

fix(bpm-core): respect manager resolution priority when building approvers #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fantasywind merged 3 commits into from
Aug 4, 2026
Merged

fix(bpm-core): respect manager resolution priority when building approvers #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb6d4ff
fix(bpm-core): respect manager resolution priority when building appr…
coollugi Aug 3, 2026
6b07cc6
feat(shared): add preferClosestOrgUnit flag to manager resolver types
fantasywind Aug 3, 2026
36c687e
feat(bpm-core): add opt-in org-unit depth filtering for manager resol…
fantasywind Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
276 changes: 274 additions & 2 deletions libs/bpm-core/src/lib/workflow-engine/workflow-engine.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,265 @@ describe('WorkflowEngineService', () => {
});
});

it('ignores lower-priority manager rules inherited from ancestor org units', async (): Promise<void> => {
const fixture = createServiceFixture({
currentVersionId: 'template-version-1',
formVersionStatus: FormDefinitionVersionStatusEnum.PUBLISHED,
processManagerResolutions: [
createManagerResolution({
id: 'manager-resolution-company',
managerMemberId: 'member-ceo',
priority: 10,
scopeId: 'org-company',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
createManagerResolution({
id: 'manager-resolution-finance',
managerMemberId: 'member-manager',
priority: 100,
scopeId: 'org-finance',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
],
processMemberships: [
createMembership({
memberId: 'member-001',
orgUnitId: 'org-finance',
}),
],
processOrgUnits: [
createOrgUnit({ id: 'org-company', path: 'org' }),
createOrgUnit({ id: 'org-finance', path: 'org.finance' }),
],
processWorkflowSnapshot: createLinearUserTaskWorkflow({
approverResolver: {
baseFromInitiator: true,
levelsUp: 1,
type: 'ORG_MANAGER',
},
}),
templateVersionStatus: ApprovalTemplateVersionStatusEnum.PUBLISHED,
});

await fixture.service.processInstance('instance-1');

expect(fixture.savedTasks[0]).toMatchObject({
assigneeMemberId: 'member-manager',
});
expect(
fixture.savedTaskCandidates.map((candidate) => candidate.memberId),
).toEqual(['member-manager']);
});

it('keeps every manager rule that ties on the winning tier', async (): Promise<void> => {
const fixture = createServiceFixture({
currentVersionId: 'template-version-1',
formVersionStatus: FormDefinitionVersionStatusEnum.PUBLISHED,
processManagerResolutions: [
createManagerResolution({
id: 'manager-resolution-finance-a',
managerMemberId: 'member-manager-a',
priority: 100,
scopeId: 'org-finance',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
createManagerResolution({
id: 'manager-resolution-finance-b',
managerMemberId: 'member-manager-b',
priority: 100,
scopeId: 'org-finance',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
createManagerResolution({
id: 'manager-resolution-company',
managerMemberId: 'member-ceo',
priority: 10,
scopeId: 'org-company',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
],
processMemberships: [
createMembership({
memberId: 'member-001',
orgUnitId: 'org-finance',
}),
],
processOrgUnits: [
createOrgUnit({ id: 'org-company', path: 'org' }),
createOrgUnit({ id: 'org-finance', path: 'org.finance' }),
],
processWorkflowSnapshot: createLinearUserTaskWorkflow({
approverResolver: {
baseFromInitiator: true,
levelsUp: 1,
type: 'ORG_MANAGER',
},
}),
templateVersionStatus: ApprovalTemplateVersionStatusEnum.PUBLISHED,
});

await fixture.service.processInstance('instance-1');

expect(
fixture.savedTaskCandidates.map((candidate) => candidate.memberId).sort(),
).toEqual(['member-manager-a', 'member-manager-b']);
});

it('keeps both org-unit tiers when preferClosestOrgUnit is not set', async (): Promise<void> => {
const fixture = createServiceFixture({
currentVersionId: 'template-version-1',
formVersionStatus: FormDefinitionVersionStatusEnum.PUBLISHED,
processManagerResolutions: [
createManagerResolution({
id: 'manager-resolution-finance',
managerMemberId: 'member-manager',
priority: 100,
scopeId: 'org-finance',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
createManagerResolution({
id: 'manager-resolution-company',
managerMemberId: 'member-ceo',
priority: 100,
scopeId: 'org-company',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
],
processMemberships: [
createMembership({
memberId: 'member-001',
orgUnitId: 'org-finance',
}),
],
processOrgUnits: [
createOrgUnit({ id: 'org-company', path: 'org' }),
createOrgUnit({ id: 'org-finance', path: 'org.finance' }),
],
processWorkflowSnapshot: createLinearUserTaskWorkflow({
approverResolver: {
baseFromInitiator: true,
levelsUp: 1,
type: 'ORG_MANAGER',
},
}),
templateVersionStatus: ApprovalTemplateVersionStatusEnum.PUBLISHED,
});

await fixture.service.processInstance('instance-1');

expect(
fixture.savedTaskCandidates.map((candidate) => candidate.memberId).sort(),
).toEqual(['member-ceo', 'member-manager']);
});

it('keeps only the deepest org unit when preferClosestOrgUnit is enabled', async (): Promise<void> => {
const fixture = createServiceFixture({
currentVersionId: 'template-version-1',
formVersionStatus: FormDefinitionVersionStatusEnum.PUBLISHED,
processManagerResolutions: [
createManagerResolution({
id: 'manager-resolution-finance',
managerMemberId: 'member-manager',
priority: 100,
scopeId: 'org-finance',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
createManagerResolution({
id: 'manager-resolution-company',
managerMemberId: 'member-ceo',
priority: 100,
scopeId: 'org-company',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
],
processMemberships: [
createMembership({
memberId: 'member-001',
orgUnitId: 'org-finance',
}),
],
processOrgUnits: [
createOrgUnit({ id: 'org-company', path: 'org' }),
createOrgUnit({ id: 'org-finance', path: 'org.finance' }),
],
processWorkflowSnapshot: createLinearUserTaskWorkflow({
approverResolver: {
baseFromInitiator: true,
levelsUp: 1,
preferClosestOrgUnit: true,
type: 'ORG_MANAGER',
},
}),
templateVersionStatus: ApprovalTemplateVersionStatusEnum.PUBLISHED,
});

await fixture.service.processInstance('instance-1');

expect(
fixture.savedTaskCandidates.map((candidate) => candidate.memberId),
).toEqual(['member-manager']);
});

it('keeps sibling org units at the same depth when preferClosestOrgUnit is enabled', async (): Promise<void> => {
const fixture = createServiceFixture({
currentVersionId: 'template-version-1',
formVersionStatus: FormDefinitionVersionStatusEnum.PUBLISHED,
processManagerResolutions: [
createManagerResolution({
id: 'manager-resolution-finance-a',
managerMemberId: 'member-manager-a',
priority: 100,
scopeId: 'org-finance-a',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
createManagerResolution({
id: 'manager-resolution-finance-b',
managerMemberId: 'member-manager-b',
priority: 100,
scopeId: 'org-finance-b',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
createManagerResolution({
id: 'manager-resolution-company',
managerMemberId: 'member-ceo',
priority: 100,
scopeId: 'org-company',
scopeType: ManagerResolutionScopeTypeEnum.ORG_UNIT,
}),
],
processMemberships: [
createMembership({
memberId: 'member-001',
orgUnitId: 'org-finance-a',
}),
createMembership({
memberId: 'member-001',
orgUnitId: 'org-finance-b',
}),
],
processOrgUnits: [
createOrgUnit({ id: 'org-company', path: 'org' }),
createOrgUnit({ id: 'org-finance-a', path: 'org.finance_a' }),
createOrgUnit({ id: 'org-finance-b', path: 'org.finance_b' }),
],
processWorkflowSnapshot: createLinearUserTaskWorkflow({
approverResolver: {
baseFromInitiator: true,
levelsUp: 1,
preferClosestOrgUnit: true,
type: 'ORG_MANAGER',
},
}),
templateVersionStatus: ApprovalTemplateVersionStatusEnum.PUBLISHED,
});

await fixture.service.processInstance('instance-1');

expect(
fixture.savedTaskCandidates.map((candidate) => candidate.memberId).sort(),
).toEqual(['member-manager-a', 'member-manager-b']);
});

it('stops with a clear error when the initiator manager cannot be resolved', async (): Promise<void> => {
const fixture = createServiceFixture({
currentVersionId: 'template-version-1',
Expand Down Expand Up @@ -1995,6 +2254,7 @@ interface ServiceFixture {
readonly savedProcessLog: ActivityLogEntity | null;
readonly savedProcessToken: WorkflowTokenEntity | null;
readonly savedSingleActivityLogs: readonly ActivityLogEntity[];
readonly savedTaskCandidates: readonly TaskCandidateEntity[];
readonly savedTasks: readonly TaskEntity[];
readonly savedWorkflowTokens: readonly WorkflowTokenEntity[];
readonly savedToken: WorkflowTokenEntity | null;
Expand Down Expand Up @@ -2080,6 +2340,7 @@ function createServiceFixture({
let savedActivityLogs: readonly ActivityLogEntity[] = [];
let savedSingleActivityLogs: readonly ActivityLogEntity[] = [];
let savedTasks: readonly TaskEntity[] = [];
let savedTaskCandidates: readonly TaskCandidateEntity[] = [];
const template = createTemplate(currentVersionId);
const templateVersion = createTemplateVersion(templateVersionStatus);
const formVersion = createFormVersion(formVersionStatus, formSchema);
Expand Down Expand Up @@ -2454,8 +2715,16 @@ function createServiceFixture({
save: jest.fn(
(
entityOrEntities: TaskCandidateEntity | TaskCandidateEntity[],
): Promise<TaskCandidateEntity | TaskCandidateEntity[]> =>
Promise.resolve(entityOrEntities),
): Promise<TaskCandidateEntity | TaskCandidateEntity[]> => {
savedTaskCandidates = [
...savedTaskCandidates,
...(Array.isArray(entityOrEntities)
? entityOrEntities
: [entityOrEntities]),
];

return Promise.resolve(entityOrEntities);
},
),
});
const transactionalTaskDecisionRepository =
Expand Down Expand Up @@ -2632,6 +2901,9 @@ function createServiceFixture({
get savedSingleActivityLogs(): readonly ActivityLogEntity[] {
return savedSingleActivityLogs;
},
get savedTaskCandidates(): readonly TaskCandidateEntity[] {
return savedTaskCandidates;
},
get savedTasks(): readonly TaskEntity[] {
return savedTasks;
},
Expand Down
Loading
Loading