Repository navigation
Integrate Triton-RISCV agent backend and workbench with Harness - #2
Merged
shirohasuki merged 3 commits intoOct 8, 2026
Merged
Conversation
shirohasuki
requested changes
Oct 1, 2026
Collaborator
There was a problem hiding this comment.
Documents written by AI do not need to be added to the repository. Documents are intended for human readers; the AI will analyse the code itself and does not require documentation.
| - id: triton-riscv-native-host | ||
| config: | ||
| enabled: false | ||
| repoRoot: '' # Absolute operator checkout path |
Collaborator
There was a problem hiding this comment.
I don't suggest writing repoRoot: before excustion. What if we have more than one working repository?
| const tokenBudget = e.tokenBudget ?? null | ||
| if (tokenBudget !== null && (!Number.isInteger(tokenBudget) || tokenBudget <= 0)) | ||
| throw new Error('embedding.tokenBudget must be a positive integer') | ||
| const env = { |
Collaborator
There was a problem hiding this comment.
There are rather too many environment variables; to be honest, they’re difficult to maintain.
Collaborator
|
Thanks for your time. I've left some comments. |
shirohasuki
approved these changes
Oct 8, 2026
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the existing Triton-RISCV Agent into an installable Harness plugin under
packages/dsh-triton-riscv/. This PR includes the full plugin integration, not only a cleanup.Repository-level changes are limited to the necessary installation, configuration, and check integration. Other plugins' business logic is unchanged. Credentials, databases, logs, virtual environments, and local host copies are excluded.
Related Issue
Follow-up to #1 and its review comments.
Addresses the previous feedback by separating prompt responsibilities, clarifying MCP installation scope, using config.yml, passing explicit configuration parameters, and organizing Vitest coverage around inputs, outputs, and state.
See
packages/dsh-triton-riscv/REVIEW_FOLLOWUP.mdfor details. This PR does not automatically close the earlier PR.Validation
Completed local checks:
Integration tests use temporary fixtures and scripted model responses. They do not represent a fresh live-model or RISC-V numerical acceptance run.
The repository-level
pnpm test:unitrun passed 59 tests, but the agent-observer suite could not load because the local@deepseek-ai/dsh-toolsdependency was missing. That suite was neither modified nor skipped. Full repository CI is not yet certified.Workbench Demo
Requires Node >=22.19, Python >=3.10, and an existing operator checkout:
Open http://127.0.0.1:8765. Setup installs dependencies on the user's machine. Native Harness installation and configuration are documented in the plugin README. Live model calls and remote validation require the user's API credentials, SSH access, and RISC-V toolchain.
This is a trusted local development tool, not a hardened public multi-user service. Plugin approvals do not replace host sandboxing.
Checklist