Skip to content

Added new params for ISettings to support 3dInference#303

Merged
Sirsho1997 merged 1 commit into
mainfrom
feature-trellis-additional-params
May 29, 2026
Merged

Added new params for ISettings to support 3dInference#303
Sirsho1997 merged 1 commit into
mainfrom
feature-trellis-additional-params

Conversation

@Sirsho1997
Copy link
Copy Markdown
Collaborator

Added

  • IMeshCluster dataclass for settings.meshCluster:
    • thresholdConeHalfAngleRad: Optional[float]
    • refineIterations: Optional[int]
    • globalIterations: Optional[int]
    • smoothStrength: Optional[int]
  • ISettings:
    • textureFormat: Optional[str]
    • alphaMode: Optional[str]
    • remeshBand: Optional[float]
    • remeshProject: Optional[float]
    • meshCluster: Optional[Union[IMeshCluster, Dict[str, Any]]]

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b88e505a-9d78-409d-86d3-168dfcc14076

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feature-trellis-additional-params

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new optional fields to ISettings for 3D inference support, including a new IMeshCluster dataclass and several scalar settings.

Changes:

  • New IMeshCluster dataclass with mesh clustering parameters.
  • Added textureFormat, alphaMode, remeshBand, remeshProject, and meshCluster fields to ISettings.
  • Updated ISettings.__post_init__ to coerce dict meshCluster into IMeshCluster.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@Sirsho1997 Sirsho1997 merged commit 5eb19f8 into main May 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants