Skip to content

Sync decisions contract for InferenceInfra #5208 (Eve format 4) - #208

Merged
shubhammalhotra28 merged 1 commit into
mainfrom
sync/decisions-eve-format4
Oct 17, 2026
Merged

shubhammalhotra28 merged 1 commit into
mainfrom
sync/decisions-eve-format4

Conversation

@AmanSwar

@AmanSwar AmanSwar commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Sync of the vendored decisions contract for InferenceInfra #5208: Eve (pplx-decider) moves to v1.2, which answers prompt_format_version 4.

  • contracts/wally-decisions-public-v1.openapi.json: re-vendored from InferenceInfra ecd738b257. The prompt_format_version enums gain 4, and their descriptions change.
  • src/account/decisions_contract.rs: regenerated. Only CONTRACT_SHA256 moves, because the reader takes the version as an integer with no enum check.
  • versions.toml: the decisions_source_commit and decisions_contract_sha256 pins.

There's no behaviour change for Wally. It never pins prompt_format_version, and it already reads any integer.

Why now: InferenceInfra's consumer-impact check keeps #5208 red until this pin matches it. This PR merges first, then #5208. The monorepo has a sibling PR that does the same.

python3 contracts/sync_from_inferenceinfra.py --check passes. The cargo tests need the kit, so CI runs them.


Summary by cubic

Syncs the vendored InferenceInfra decisions contract so prompt_format_version 4 (Eve v1.2) is accepted.

  • Re-vendors the OpenAPI contract from InferenceInfra ecd738b257, adding 4 to the request and response prompt_format_version enums and updating their descriptions.
  • Regenerates src/account/decisions_contract.rs; only CONTRACT_SHA256 changes because the reader takes the version as an integer with no enum check.
  • Updates the decisions_source_commit and decisions_contract_sha256 pins in versions.toml.

No behavior change for Wally: it never pins prompt_format_version and already reads any integer. This merge unblocks InferenceInfra #5208, so merge it first.

Written for commit 9ce1c27. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • API Updates
    • The decisions API now accepts prompt format version 4 alongside versions 2 and 3.
    • Requests and responses document that models may support two prompt format versions during a wording transition.

…e format 4)

prompt_format_version gains 4 (pplx-decider-v1.2's wording) in the request
and response enums. Vendored from InferenceInfra ecd738b257; the binding is
regenerated (only its contract hash moves: the reader takes the version as an
integer) and versions.toml pins the new commit and sha256.
@AmanSwar
AmanSwar requested a review from a team as a code owner October 17, 2026 00:02
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 94db16cd-8d94-45f7-a756-82f14be8f387
📥 Commits

Reviewing files that changed from the base of the PR and between f609fd1 and 9ce1c27.

📒 Files selected for processing: 3
  • contracts/wally-decisions-public-v1.openapi.json
  • src/account/decisions_contract.rs
  • versions.toml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The decisions contract now accepts prompt format version 4 and documents responses during a wording transition. The request and response schema hashes, Rust contract digest, and source pins were updated.

Changes: Decisions contract versioning

Layer / File(s) Summary
Prompt version schema
contracts/wally-decisions-public-v1.openapi.json
The request and response schemas now allow prompt format version 4 and describe serving two versions during a wording transition. The recorded schema hashes were updated.
Contract digest and source pins
src/account/decisions_contract.rs, versions.toml
The Rust contract digest and the source commit and digest pins were updated.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 9ce1c

Wally’s request and response contracts now accept version 4, and the local digest pins agree. No concrete merge-blocking issue is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: syncing the decisions contract with InferenceInfra and adding Eve format 4 support.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shubhammalhotra28
shubhammalhotra28 merged commit 9a577fb into main Oct 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants