Repository navigation
Convert Golden PROJECT workflow scenarios to TypeScript - #546
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the Golden PROJECT workflow scenarios to TypeScript, update the catalog and subprocess test paths, and remove the converted module from the JavaScript language-policy baseline.
The three scenarios now satisfy the existing
GoldenScenariocontract. Named evidence shapes replace inline JSDoc shapes and reuse the native worktree registry entry type. Existing assertions at the opaque Golden result-state boundary remain; typed child-plan tuples and named parent metadata remove redundant casts. Scripts, actions, assertions, timeouts, coverage claims, and scenario ordering are unchanged.Validation:
.tsmodule paths.The initial source shard 4 run hit the unrelated rollover debugger fixture error “Rollover source was not loaded by the laptop process” in the “successor starts” case. The exact case passes on untouched main, and all six rollover cases pass on this branch. The failed CI jobs passed on retry without a code change; the full source and Golden gates are green.