Skip to content

Convert initial Golden TUI scenarios to TypeScript - #545

Merged
gandazgul merged 1 commit into
mainfrom
codex/ts-initial-golden-scenarios
Nov 4, 2026
Merged

gandazgul merged 1 commit into
mainfrom
codex/ts-initial-golden-scenarios

Conversation

@gandazgul

Copy link
Copy Markdown
Collaborator

Convert the initial Golden TUI scenarios to TypeScript and update their catalog and subprocess test paths. Remove the converted module from the JavaScript language-policy baseline.

Scenario definitions now satisfy the existing GoldenScenario contract. Named Plan review evidence types replace inline JSDoc shapes and reuse consumed-review/interaction types from the public testing surface. Localized assertions remain at the existing opaque Golden result-state boundary. Scenario data, assertions, timeouts, diagnostic failures, and collection order are unchanged.

Validation:

  • All 23 initial-scenario tests pass through the isolated runner, including composed TUI journeys and diagnostic child failures.
  • All 11 pre-test CI tasks pass, including type checks, lint, Workspace build, and architectural checks.
  • Emitted JavaScript AST matches the original exactly; consumer ASTs differ only in required .ts module paths.
  • Independent Standards, Spec, and Tests reviews are clear.

@gandazgul gandazgul added auto:js-to-ts Automated JavaScript to TypeScript conversion auto:review Ready for auto code review labels Nov 4, 2026
@gandazgul
gandazgul merged commit 0ceb1dc into main Nov 4, 2026
10 checks passed
@gandazgul
gandazgul deleted the codex/ts-initial-golden-scenarios branch November 4, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto:js-to-ts Automated JavaScript to TypeScript conversion auto:review Ready for auto code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant