Skip to content

Convert delegated-agent tests to TypeScript - #543

Merged
gandazgul merged 1 commit into
mainfrom
codex/ts-delegate-agent-tests
Nov 4, 2026
Merged

gandazgul merged 1 commit into
mainfrom
codex/ts-delegate-agent-tests

Conversation

@gandazgul

Copy link
Copy Markdown
Collaborator

Convert src/tools/__tests__/delegate-agent.test.js to TypeScript, update the isolated test inventory, and update three live Plan references to the new filename.

All 14 cases keep their fixtures, product calls, assertions, and cleanup. The test imports the owning DelegateAgentDetails contract, now exported from the tool module, rather than duplicating it. Native SDK types describe assistant messages, child-session options, and lease state. Localized assertions preserve the existing empty tool context and text-only result access; the invalid-role fixture still exercises runtime validation.

Validation:

  • All 14 focused cases pass through the isolated runner.
  • All 11 pre-test CI tasks pass; documentation links were checked again after the path updates.
  • Emitted JavaScript AST matches the original for both the test and owning tool.
  • Independent Standards, Spec, and Tests reviews are clear.
  • The touched Plan has pre-existing formatting warnings, confirmed against untouched main; its changes are limited to three filename extensions.

@gandazgul gandazgul added auto:js-to-ts Automated JavaScript to TypeScript conversion auto:review Ready for auto code review labels Nov 4, 2026
@gandazgul
gandazgul merged commit 0c531d2 into main Nov 4, 2026
10 checks passed
@gandazgul
gandazgul deleted the codex/ts-delegate-agent-tests branch November 4, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto:js-to-ts Automated JavaScript to TypeScript conversion auto:review Ready for auto code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant