Skip to content

Convert image attachment tests to TypeScript - #539

Merged
gandazgul merged 1 commit into
mainfrom
codex/ts-image-attachment-tests
Nov 3, 2026
Merged

gandazgul merged 1 commit into
mainfrom
codex/ts-image-attachment-tests

Conversation

@gandazgul

Copy link
Copy Markdown
Collaborator

Converts the image-attachment test module to TypeScript and updates the isolated-runner inventory. Native SessionManager, image-content, model, and fetch types replace broad annotations; named fixture shapes describe the existing settings and discovery registry. Partial SDK fixtures retain localized compatibility assertions.

All fixtures, assertions, cleanup, process-global locks, and nine test cases remain unchanged. This conversion adds no production behavior.

Validation:

  • Frozen root/docs installation with Bun 1.4.3; initialized submodules are clean.
  • All 11 preliminary CI checks pass, including type checks, lint, language policy, documentation links, and Workspace build.
  • All nine existing image-attachment tests pass; case-count delta is zero.
  • Emitted runtime JavaScript AST matches the original test file exactly.
  • Independent Standards, Spec, and Tests reviews are clear.
  • Full GitHub source and Golden CI required before merge.

@gandazgul gandazgul added auto:js-to-ts Automated JavaScript to TypeScript conversion auto:review Ready for auto code review labels Nov 3, 2026
@gandazgul
gandazgul merged commit ea90663 into main Nov 3, 2026
10 checks passed
@gandazgul
gandazgul deleted the codex/ts-image-attachment-tests branch November 3, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto:js-to-ts Automated JavaScript to TypeScript conversion auto:review Ready for auto code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant