Repository navigation
build: depend on RumbleDB through the local Maven repository instead of a system-scoped jar - #148
Merged
Merged
Conversation
…of a system-scoped jar fetch-rumble.sh now builds Rumble's thin jar and installs it with its own pom, so Rumble's runtime dependencies resolve transitively and the prod profile no longer unzips the fat jar. The version comes from the pinned commit via .mvn/maven.config. Spark stays declared because it is provided-scoped in Rumble.
🦋 Changeset detectedLatest commit: 471bf77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ntents The local Maven repository is shared by every checkout, so a plain 3.1.0 was overwritten by whichever checkout or Rumble build installed last. The version now comes from a hash of the jar and pom, the install is skipped when that version is already present, and the dev build cache key follows it. rumble.version gets a placeholder default so goals such as clean work before fetch-rumble.sh has run.
Write the build metadata once, after the jar is known, and cache the jar and the build signature in one place. Drop checks that can no longer fail: the change check on maven.config, the extra mkdir, the empty jar case in the metadata, and the classpath dedupe in dev.ts.
Test CI only builds the wrapper for development, so changes to the shaded release jar were first exercised at release time. The prod profile now skips surefire and runs the same tests with failsafe against the shaded jar, with only the test dependencies besides it on the classpath. A new workflow runs the prod build on changes to the wrapper.
JSONIQ_LSP_WRAPPER_JAR makes the language server start the given jar with -jar, as a release does, instead of the development build or the released jar. The release jar workflow uses it to run the server tests against the shaded jar it just built, and now also runs when the server's wrapper integration changes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maven has deprecated
system-scoped dependencies, which is how the wrapper used RumbleDB. RumbleDB is now a regular Maven dependency.Changes
fetch-rumble.shbuilds RumbleDB's plain jar and installs it into the local Maven repository. Its version is named after the jar's contents (for example3.1.0-local-660355a3f22b), so checkouts with different RumbleDB builds don't overwrite each other's copy.jackson-core2.18.2 and 2.18.6.JSONIQ_LSP_WRAPPER_JARmakes the language server use a given wrapper jar.Testing
A new workflow runs when the wrapper changes. It builds the release jar, then runs the wrapper tests and the language server tests against it.