Skip to content

build: depend on RumbleDB through the local Maven repository instead of a system-scoped jar - #148

Merged
CaiJimmy merged 8 commits into
mainfrom
build/rumble-maven-dependency
Nov 16, 2026
Merged

CaiJimmy merged 8 commits into
mainfrom
build/rumble-maven-dependency

Conversation

@CaiJimmy

@CaiJimmy CaiJimmy commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Maven has deprecated system-scoped dependencies, which is how the wrapper used RumbleDB. RumbleDB is now a regular Maven dependency.

Changes

  • fetch-rumble.sh builds RumbleDB's plain jar and installs it into the local Maven repository. Its version is named after the jar's contents (for example 3.1.0-local-660355a3f22b), so checkouts with different RumbleDB builds don't overwrite each other's copy.
  • The release jar is now shaded from Maven's dependencies, instead of unzipping RumbleDB's fat jar. It contains one version of each library; the old jar mixed jackson-core 2.18.2 and 2.18.6.
  • JSONIQ_LSP_WRAPPER_JAR makes the language server use a given wrapper jar.

Testing

A new workflow runs when the wrapper changes. It builds the release jar, then runs the wrapper tests and the language server tests against it.

…of a system-scoped jar

fetch-rumble.sh now builds Rumble's thin jar and installs it with its own
pom, so Rumble's runtime dependencies resolve transitively and the prod
profile no longer unzips the fat jar. The version comes from the pinned
commit via .mvn/maven.config. Spark stays declared because it is
provided-scoped in Rumble.
@changeset-bot

changeset-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 471bf77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
rumble-lsp-wrapper Patch
jsoniq-language-server Patch
jsoniq-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…ntents

The local Maven repository is shared by every checkout, so a plain 3.1.0
was overwritten by whichever checkout or Rumble build installed last.
The version now comes from a hash of the jar and pom, the install is
skipped when that version is already present, and the dev build cache
key follows it. rumble.version gets a placeholder default so goals such
as clean work before fetch-rumble.sh has run.
Write the build metadata once, after the jar is known, and cache the jar
and the build signature in one place. Drop checks that can no longer
fail: the change check on maven.config, the extra mkdir, the empty jar
case in the metadata, and the classpath dedupe in dev.ts.
Test CI only builds the wrapper for development, so changes to the shaded
release jar were first exercised at release time. The prod profile now
skips surefire and runs the same tests with failsafe against the shaded
jar, with only the test dependencies besides it on the classpath. A new
workflow runs the prod build on changes to the wrapper.
JSONIQ_LSP_WRAPPER_JAR makes the language server start the given jar with
-jar, as a release does, instead of the development build or the released
jar. The release jar workflow uses it to run the server tests against the
shaded jar it just built, and now also runs when the server's wrapper
integration changes.
@CaiJimmy
CaiJimmy merged commit 7ff9827 into main Nov 16, 2026
3 checks passed
@CaiJimmy
CaiJimmy deleted the build/rumble-maven-dependency branch November 16, 2026 13:37
@github-actions github-actions Bot mentioned this pull request Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant