Skip to content

Release - v0.1.30#41

Merged
akbarsaputrait merged 6 commits into
masterfrom
release/0.1.30
Jul 1, 2026
Merged

Release - v0.1.30#41
akbarsaputrait merged 6 commits into
masterfrom
release/0.1.30

Conversation

@akbarsaputrait

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
intent-example Ready Ready Preview, Comment Jun 29, 2026 7:19pm

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82653b79d3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/connectkit/package.json
@akbarsaputrait

Copy link
Copy Markdown
Member Author

Un-relevant changes moved to:
#42

@shawnmuggle

Copy link
Copy Markdown
Member

Review — Release v0.1.30

Verdict: APPROVE. No P0 blockers. Clean, low-risk release PR. The one "logic" file (usePaymentState.ts) has zero behavioral change — all 3 hunks are import-block reformat/reorder (collapse a multi-line wagmi import, move getDataSuffix import up alphabetically). No state-machine / race / deps-array / error-handling surface touched. The dataSuffix feature in the CHANGELOG landed in earlier commits; this PR only carries the cosmetic import shuffle.

Dependency safety — PASS

The ~223-line pnpm-lock.yaml churn is almost entirely benign peer-dep re-keying from the pnpm 11.3.0 → 11.9.0 bump (a (supports-color@5.5.0) suffix threaded through existing hash keys). Every "new-looking" key has an identical removed entry at the same version — no net-new packages, no downgrades, no git+/file:/alternate-registry sources. Only intentional dep change: @rozoai/intent-common 0.1.19-beta.3 → 0.1.20, resolving from npmjs with an integrity hash.

P2 — confirm before tagging

  1. Version-label mismatch. PR title + CHANGELOG.md say [0.1.30], but the shipped package versions bump to 0.1.20 (@rozoai/intent-common 0.1.19 → 0.1.20; connectkit's dep ref synced to 0.1.20 — good, so consumers resolve correctly). The discrepancy is purely the human-facing release label vs the actual published version. Recommend making the CHANGELOG heading + git tag match the real version to avoid confusion.
  2. connectkit's own version field isn't bumped in this diff — if connectkit publishes as part of this release, verify it was bumped in a prior commit (else pnpm publish may skip/re-publish the same version).
  3. bundle-analysis.html committed (rollup-visualizer artifact) — its ~250KB minified payload bloats this and every future diff. Recommend gitignoring and generating in CI.

@shawnmuggle shawnmuggle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — no P0 blockers found. See the detailed review comment for P1/P2 follow-ups worth addressing.

@akbarsaputrait akbarsaputrait merged commit a5a505c into master Jul 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants