Repository navigation
[Fix] Built-in automation settings stay stuck loading after a failed read - #3633
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed the initial-read error and retry transitions, cached settings/draft preservation, independent custom controls, and regression tests. CI lint, type checks, Knip, and CodeQL passed; tests and the app image build were still running when checked. Repository validation suites were not rerun during this review. Reviewed d45bf50 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 30, 2026 06:03
This was referenced Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Scoped product recovery work; no linked issue.
Why this PR exists
What changed
After an initial built-in automation settings read failed, the Automations page stayed on loading skeletons without an error or recovery action. The default destination and built-in controls remained unavailable even after connectivity returned.
The failed initial read now shows a compact Retry action instead of indefinite placeholders. The error stays visible while Retry runs, duplicate attempts are disabled, and success restores the existing destination and built-in controls in place. Independent custom automation controls remain available when their own reads have loaded.
Why this change was made
An exhausted read should be distinguishable from loading and recoverable without reloading the page. This uses the existing query and one transient retry flag; it introduces no API, setting, dependency or save-policy change.
Impact
Users can recover the built-in settings journey where it failed. Cached settings and open drafts retain their existing background-refresh behavior; this does not introduce a new background Retry/reset flow.
How it was tested
c97173a7: interrupted the actual request containingautomations.getSettings. After four native attempts, the page had 18 skeletons, no error alert and no Retry. Removing the interruption did not restore built-in settings.d45bf50d44b7f5ac97e2415b8858d15ca27bd04d.Screenshots
Desktop failed initial read and real settings restored by Retry:
Mobile failed initial read and real restored settings:
Related PRs
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetNormal fast static gates were used; formatting-inclusive full commands and a changeset were not run.