Skip to content

[Fix] Starting a session goal fails without feedback #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roomote-roomote wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Fix] Starting a session goal fails without feedback #3632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions apps/web/src/app/(sandbox)/sessions/[sessionId]/FastSessionTranscript.client.test.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 18 additions & 8 deletions apps/web/src/app/(sandbox)/sessions/[sessionId]/SessionPromptInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,16 +389,26 @@ export function SessionPromptInput({
toast.error('Goal Mode does not support attachments.');
return false;
}
const result = await trpcClient.fastSessions.startGoal.mutate({
sessionId,
objective,
});
if (!result.success) {
toast.error(result.error);
try {
const result = await trpcClient.fastSessions.startGoal.mutate({
sessionId,
objective,
});
if (!result.success) {
toast.error(result.error);
return false;
}
toast.success(`Pursuing goal: ${objective}`);
sent = true;
} catch (error) {
toast.error('Could not start the goal.', {
description:
error instanceof Error && error.message
? error.message
: 'Try again shortly.',
});
return false;
}
toast.success(`Pursuing goal: ${objective}`);
sent = true;
} else {
// Always send the current picker state: it round-trips the persisted
// choice and clears it when the picker is reset to the default.
Expand Down
Loading