Repository navigation
[Improve] Keep personal sessions in the sidebar recent list - #3488
Closed
roomote-community[bot] wants to merge 2 commits into
Closed
roomote-community[bot] wants to merge 2 commits into
roomote-community[bot] wants to merge 2 commits into
Conversation
Contributor
Author
|
No new code issues found. Both parent SideNav expectations now match the query input; the prior finding is addressed and its thread is resolved. Current-head CI lint, type checks, knip, and docs checks passed; tests and Docker build were still running when checked. See task
Reviewed a933d26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Requested sidebar improvement; no linked issue.
Why this PR exists
Automation runs can crowd personal sessions out of the sidebar's bounded recent list.
What changed
excludeAutomationson the existing session-list query. SQL filters the persistedownerKindbefore the limit and cursor page are computed.How it was tested
src/lib/server/sessions.test.ts,src/trpc/routers/sessions.test.ts, andsrc/components/layout/side-nav/RecentSessions.client.test.tsxusing the web package Vitest command with.env.test.SideNav.client.test.tsxexact query expectations includeexcludeAutomations: truefor expanded and collapsed states. All 25 tests pass acrossSideNav.client.test.tsxandRecentSessions.client.test.tsx; all pre-push gates pass on the updated head.pnpm lint:fast,pnpm check-types:fast,pnpm knip,mise exec -- pnpm --filter @roomote/docs check, andgit diff --checkpassed. Pre-commit formatting and all pre-push gates passed. Formatting-inclusive fullpnpm lint/pnpm check-typeswere not run.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset