Skip to content

[Improve] Keep personal sessions in the sidebar recent list - #3488

Closed
roomote-community[bot] wants to merge 2 commits into
developfrom
fix/sidebar-automation-sessions-3shofka8e7inb
Closed

roomote-community[bot] wants to merge 2 commits into
developfrom
fix/sidebar-automation-sessions-3shofka8e7inb

Conversation

@roomote-community

@roomote-community roomote-community Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

​Opened on behalf of @zarnivoop. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related issue

Requested sidebar improvement; no linked issue.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

Automation runs can crowd personal sessions out of the sidebar's bounded recent list.

What changed

  • Recent sessions opts into excludeAutomations on the existing session-list query. SQL filters the persisted ownerKind before the limit and cursor page are computed.
  • The classification covers custom and built-in automation origins for both task-backed and conversational sessions. It does not infer provenance from titles, source surfaces, triggers, or tasks later attached to a human-origin session.
  • Other callers retain existing defaults, including the main sessions list and automation history. Ownership, privacy, and access predicates remain intact. Viewing or participating in automation sessions does not re-include them in Recent sessions.
  • Document the sidebar behavior in the sessions guide.

How it was tested

  • 45 tests passed across src/lib/server/sessions.test.ts, src/trpc/routers/sessions.test.ts, and src/components/layout/side-nav/RecentSessions.client.test.tsx using the web package Vitest command with .env.test.
  • Database-backed regressions verify custom-owner exclusion, built-in task and conversational provenance, filtering before pagination with full pages/correct end cursors, omitted/false defaults, automation history, private-session access, and preservation of human-origin sessions even with automation-like titles, webhook origin, or attached automation work.
  • Sidebar regressions verify the opt-in query, ordering, active/unread cues, retry behavior, and empty state.
  • Follow-up: both parent SideNav.client.test.tsx exact query expectations include excludeAutomations: true for expanded and collapsed states. All 25 tests pass across SideNav.client.test.tsx and RecentSessions.client.test.tsx; all pre-push gates pass on the updated head.
  • pnpm lint:fast, pnpm check-types:fast, pnpm knip, mise exec -- pnpm --filter @roomote/docs check, and git diff --check passed. Pre-commit formatting and all pre-push gates passed. Formatting-inclusive full pnpm lint / pnpm check-types were not run.
  • Real local database fixtures and dev-login verified the rendered sidebar omission alongside main-list retention on the initial implementation. No new browser proof applies to the test-only follow-up. The docs preview returned Internal Server Error, so rendered docs verification remains unavailable despite successful Mintlify build validation and link checks.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-community

roomote-community Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

No new code issues found. Both parent SideNav expectations now match the query input; the prior finding is addressed and its thread is resolved. Current-head CI lint, type checks, knip, and docs checks passed; tests and Docker build were still running when checked. See task

Reviewed a933d26

@roomote-roomote roomote-roomote Bot closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant