Repository navigation
[Fix] API-key integration setup is erased after a failed save - #3486
Closed
roomote-roomote[bot] wants to merge 1 commit into
Closed
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See task Reviewed the key-input ref, metadata retention, pending/error/retry flow, shared and personal callers, input primitive, schema/API contract, and regression test. Current-head lint, type checking and Knip passed; tests, Docker build and JavaScript/TypeScript analysis were still running when checked. Repository validation suites were left to CI. Reviewed 05449fa |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 15, 2026 05:59
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal maintainer-requested recovery work; no issue opened.
Why this PR exists
A failed API-key integration save clears the entered name, origin and lifetime along with the key. Re-entering the key should be enough to retry an otherwise complete setup.
What changed
Clear only the key input immediately after starting the request. Keep nonsensitive setup fields intact while the request is pending and after a failure. Successful creation still closes the dialog; shared/personal visibility, validation and busy guarding are unchanged. One input ref replaces the full-form reset; no new state, API, schema, dependencies or UI controls.
How it was tested
05449fa14caa2c494b2d30a63f90e77782d307c0: induced network failure, metadata/key-state assertions, remove fault, enter only a replacement fake key, actual Save, direct PostgreSQL metadata/scope readback, then actual Remove and cleanup. Repeated for shared and personal paths. Final database readback confirms zero proof integrations and unchanged empty shared guidance.127.0.0.1:3000for its real same-origin API checks.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetScreenshots
Disclosed network-fault injection on the actual shared/personal form. These prove retained nonsensitive fields, empty key and readable recovery layout under an induced failure; they do not prove a live outage or backend correctness. Success and cleanup were separately verified through the real local API and PostgreSQL. Desktop 1440×1000; mobile 390×844.
Related PRs