Repository navigation
[ROS2PoseControl] fix build with ROS 2 Lyrical - #190
Merged
Merged
Conversation
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
jhanca-robotecai
requested review from
arturkamieniecki and
patrykantosz
as code owners
September 16, 2026 10:49
mateuszwasilewski
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a build failure against ROS 2 Lyrical where the deprecated mutable-
SharedPtrsubscription callback overload is treated as an error under-Werror -Wdeprecated-declarations. Switched toConstSharedPtr, which is backward-compatible with older distros (Humble, Jazzy) since that overload has always been supported.How to test
Builds and runs.
Screenshots / Logs / Supporting Evidence (if applicable)
Add screenshots, terminal logs, or relevant links to builds/tests as needed.
Committer Checklist
Please confirm the following before marking this PR as ready for review: