Repository navigation
[2605] WheelAnimTool: remove Eigen dependency + fix rotation - #184
Merged
Merged
Conversation
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
michalpelka
approved these changes
Jun 29, 2026
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
knicked
approved these changes
Jun 29, 2026
knicked
left a comment
There was a problem hiding this comment.
I applied the suggested updates in RobotecAI/agentic-mobile-manipulator#32 and tested the changes, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
InitJacobian: the position-gathering loop ran twice, causingmeanWheelPositionto accumulate 2x the correct sum and shifting all relative wheel positionsm_wheelAxisSigncomputed at activation by comparing each wheel entity's spin axis direction against the robot body's spin axisAZ::Math:Eigen::MatrixXd->AZ::MatrixMxNEigen::VectorXd->AZ::VectorNEigen::Vector3d/Eigen::Vector2d->AZ::Vector3/AZ::Vector2AZ::VectorMatrixMultiplyRemoving Eigen was done to solve RobotecAI/agentic-mobile-manipulator#31
The version of the Gem was updated to
2.0.0, as 1.x.y serie is used for o3de-2505 branch.How was this PR tested?
Tested using https://github.com/RobotecAI/agentic-mobile-manipulator/ demo project

The Robot needed updates of the controller:
Screenshots / Logs / Supporting Evidence (if applicable)
wheel_anim.mp4
Committer Checklist
Please confirm the following before marking this PR as ready for review: