Skip to content

[2605] ROS2PoseControl for 2605 - #181

Merged
jhanca-robotecai merged 3 commits into
o3de-2605from
pj/2605-ros2posecontrol
Mar 25, 2026
Merged

jhanca-robotecai merged 3 commits into
o3de-2605from
pj/2605-ros2posecontrol

Conversation

@pijaro

@pijaro pijaro commented Mar 24, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Updated ROS2PoseControl for o3de-2605.


How was this PR tested?

  • Build with o3de stabilization/26050 and o3de-extras development.
  • Spawned prefab and moved via pose topic.

Committer Checklist

Please confirm the following before marking this PR as ready for review:

  • Code changes are well-documented
  • Tests have been added or updated
  • Code owners file and CI config were updated if new Gem was added
  • The code is formatted according to the project's style guide
  • The version number has been updated according to the contributing guidelines

Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>

@jhanca-robotecai jhanca-robotecai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does not build on my machine,
o3de: 5005ef02d9
o3de-extras: faacbbe0

Btw. shouldn't we consider f75ae2e fix as well? I am not sure where does it come from though...

Comment thread Gems/ROS2PoseControl/Code/Source/Clients/ROS2PoseControl.cpp Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does not build on my machine:

[build] /home/jhanca/devroot/gems/robotec-o3de-tools/Gems/ROS2PoseControl/Code/Source/Clients/ROS2PoseControl.cpp:24:10: fatal error: 'LmbrCentral/Scripting/TagComponentBus.h' file not found
[build] #include <LmbrCentral/Scripting/TagComponentBus.h>
[build]          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[build] 1 error generated.

I had to add Gem::LmbrCentral.API dependency to NAME ${gem_name}.Private.Object STATIC

@pijaro pijaro Mar 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strange.

My setup is: o3de/o3de@77bbad3 (sdk) + o3de/o3de-extras@faacbbe

and it works just fine (did a clean build seconds ago). Maybe the problem is between the SDK and non-SDK versions? I can add that target - no problem - but the question of why it happens remains.

pijaro added 2 commits March 25, 2026 09:27
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
@pijaro

pijaro commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

Review applied.

As for f75ae2e, I suggest making a separate PR for that, so we can properly check it, bump versions etc.

Lets keep this PR just for migration only.

@pijaro
pijaro requested a review from jhanca-robotecai March 25, 2026 08:31

@jhanca-robotecai jhanca-robotecai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, good job

@jhanca-robotecai
jhanca-robotecai merged commit 7907d81 into o3de-2605 Mar 25, 2026
1 check passed
@jhanca-robotecai
jhanca-robotecai deleted the pj/2605-ros2posecontrol branch March 25, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants