Repository navigation
[2605] ROS2PoseControl for 2605 - #181
Conversation
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
jhanca-robotecai
left a comment
There was a problem hiding this comment.
The code does not build on my machine,
o3de: 5005ef02d9
o3de-extras: faacbbe0
Btw. shouldn't we consider f75ae2e fix as well? I am not sure where does it come from though...
There was a problem hiding this comment.
The code does not build on my machine:
[build] /home/jhanca/devroot/gems/robotec-o3de-tools/Gems/ROS2PoseControl/Code/Source/Clients/ROS2PoseControl.cpp:24:10: fatal error: 'LmbrCentral/Scripting/TagComponentBus.h' file not found
[build] #include <LmbrCentral/Scripting/TagComponentBus.h>
[build] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[build] 1 error generated.
I had to add Gem::LmbrCentral.API dependency to NAME ${gem_name}.Private.Object STATIC
There was a problem hiding this comment.
This is strange.
My setup is: o3de/o3de@77bbad3 (sdk) + o3de/o3de-extras@faacbbe
and it works just fine (did a clean build seconds ago). Maybe the problem is between the SDK and non-SDK versions? I can add that target - no problem - but the question of why it happens remains.
|
Review applied. As for f75ae2e, I suggest making a separate PR for that, so we can properly check it, bump versions etc. Lets keep this PR just for migration only. |
jhanca-robotecai
left a comment
There was a problem hiding this comment.
Works as expected, good job
What does this PR do?
Updated
ROS2PoseControlfor o3de-2605.How was this PR tested?
stabilization/26050and o3de-extras development.Committer Checklist
Please confirm the following before marking this PR as ready for review: