Repository navigation
Conversation
Fail-closed validation so pass budgets cannot be inflated with negative extra tool-call allowances. Reject bool (int subclass) before coercion. Signed-off-by: Bartok9 <183148895+Bartok9@users.noreply.github.com>
Member
|
Closing, though there was more behind this one than the rest. A negative extra_tool_calls really does drop max_tool_calls_number below required_calls and skew results instead of erroring. If we take it, it will be ge=0 on the pydantic field rather than a validator plus a test module, so I would rather fold it in next time that file is open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negative
extra_tool_callscould inflate tool-calling pass budgets. Validate>= 0and reject bool before coercion.AI-assisted; human-reviewed.
Claim: bartok
Operator: bartok
Campaign: aerial-drone