Repository navigation
fix: housekeep tool and tests - #37
Merged
Merged
Conversation
Signed-off-by: Kacper Dąbrowski <kacper.dabrowski@robotec.ai>
Signed-off-by: Kacper Dąbrowski <kacper.dabrowski@robotec.ai>
Signed-off-by: Kacper Dąbrowski <kacper.dabrowski@robotec.ai>
knicked
force-pushed
the
kd/housekeep_fix
branch
from
July 10, 2026 11:42
a2c0cb9 to
5ac0031
Compare
boczekbartek
self-requested a review
July 10, 2026 14:32
boczekbartek
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Housekeep tool would ignore moveit errors and treat them as "side not available" (for housekeeping), making failing tests pass.
When a housekeep test fails (probably because of a moveit error, or a human getting deadlocked in the way of the robot), it makes no sense to run the next test, because it will also fail. So a simulation reset is triggered that will put the robot and human back into a valid configuration.