Repository navigation
fix: catch llm exceptions in ros2 agents - #36
Merged
Merged
Conversation
Signed-off-by: Kacper Dąbrowski <kacper.dabrowski@robotec.ai>
Signed-off-by: Kacper Dąbrowski <kacper.dabrowski@robotec.ai>
knicked
force-pushed
the
kd/catch_llm_errors
branch
from
July 10, 2026 11:42
3d7b65f to
bdb545b
Compare
boczekbartek
approved these changes
Jul 10, 2026
boczekbartek
left a comment
boczekbartek
left a comment
Member
There was a problem hiding this comment.
Please check my comment, otherwise LGTM!
Signed-off-by: Kacper Dąbrowski <kacper.dabrowski@robotec.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a moveit2 or nav2 tool fails, and the llm call also fails, then the exception is unhandled and the tool service does not respond. This PR catches those exceptions and makes the tool respond with the raw error code.