Repository navigation
jazzy: fix MoveIt Task Constructor's Python bindings for MSVC (win-64) - #73
Merged
Merged
Conversation
0.1.8's Python bindings fail with MSVC C3881/C3210 in core.h (PR CI), with no obvious fix; moveit2_tutorials needs moveit_task_constructor_core. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… of excluding it core.h names the trampolines' template parameters after the classes they default to (Stage, Generator, ...), so MSVC resolves `using Stage::Stage` and friends to the namespace classes and rejects them (C3881/C3210). Rename them to T in the win patch and keep MTC and moveit2_tutorials enabled on win-64. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
changed the title
Its tutorial code uses POSIX sleep() and C++20 designated initializers (MSVC C3861/C7555 in the PR build); no distro builds it on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #59, which was merged before its jazzy win-64 job finished. The job then failed on MoveIt Task Constructor (MTC).
MTC fix (
ros2-moveit-task-constructor-core.win.patch): 0.1.8's Python bindings failed with MSVC C3881/C3210 (can only inherit constructor from direct base) inpython/bindings/src/core.h. The trampoline templates name their template parameter after the class it defaults to, e.g.template <class Stage = ...::Stage> class PyStage : public Stage { using Stage::Stage; }. MSVC resolves the name to the namespace class, so the inherited constructor names an indirect base; GCC and Clang accept it. The patch renames those parameters toT(Stage, Generator, MonitoringGenerator, PropagatingEitherWay). Windows only.moveit2_tutorials stays excluded on win-64: its tutorial code uses POSIX
sleep()(C3861) and C++20 designated initializers (C7555), and no other distribution builds it on Windows.Verified: in run 38053084059 every check passed, including jazzy win-64 with MTC core, capabilities, visualization and demo, and the zlib/zstd point cloud transport packages.
check-patchespasses on win-64, andrs checkandpixi run testpass.Together with #59, everything that jazzy excluded on win-64 now builds there, except moveit2_tutorials (and sick_safetyscanners2/rosidlcpp, which are excluded on every platform).
🤖 Generated with Claude Code