Repository navigation
Fields2cover - #175
Open
Timple wants to merge 5 commits into
Open
Fields2cover#175Timple wants to merge 5 commits into
Timple wants to merge 5 commits into
Conversation
Collaborator
|
Hi @Timple - thanks for this! I think we should unvendor as many vendored packages as possible. Especially abseil and protobuf and eigen are everywhere, so let's try and not build a (possibly incompatible) version of them here; ideally also the other vendored packages. |
Collaborator
|
As far as I understand their code, you can simply add the dependencies via conda-forge, set the BUILD_x flags to off and we should be good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.