Repository navigation
Build times: no compatibility recipes, one recipe per line - #146
Merged
Merged
Conversation
The compatibility recipes (ros-<distro>-<name>, about two thirds of the entries with jazzy's and lyrical's) only repackage and are built right after their package: collect() no longer keeps their times, and vinca_timings() gives every distribution's compatibility recipes ALIAS_SECONDS (0.3 s, the measured median), so no per-distribution copies are needed. Unmeasured recipes default to the median of the packages (ros2-*) rather than of all entries, which the compatibility recipes made nearly zero. The files keep one recipe per line, so a changed time is a one-line diff: linux-64 201 -> 72 KiB, win-64 141 -> 46 KiB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
added
the
build:none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shared/build_timings/was about 880 KiB. About two thirds of the entries were compatibility recipes (ros-jazzy-*,ros-lyrical-*), each about 0.2 s and kept once per distribution.Changes:
collect()skipsros-<distro>-*times.vinca_timings()gives every distribution's compatibility recipesALIAS_SECONDS(0.3 s, the measured median). They are built right after theirros2-package anyway (vinca#179), so their time only adds to that package's, and they need no per-distribution copies.ros2-*), not of all entries, which the compatibility recipes pulled to almost zero. lyrical's new packages had been packed as if they took no time. This also fixes what humble: rosdistro sync 2026-10-12 #62 fixes, so humble: rosdistro sync 2026-10-12 #62 will be reconciled with it."ros2-rclcpp": {"jazzy": 119.7, "lyrical": 100.3},. A changed time is a one-line diff in the weeklyupdate-build-timingsPR.Sizes:
Merging: this changes
shared/, so merging regenerates the build branches. It's best merged once lyrical's current rebuild runs have finished.Labelled
build:none. All 57 tool tests pass, andrs checkpasses.🤖 Claude (AI assistant), on behalf of @Tobias-Fischer
🤖 Generated with Claude Code