Skip to content

Applied the '.clang-format' rules to 'Vector2.hpp', 'Vector3.hpp' and 'Vector4.hpp' - #441

Merged
penggrin12 merged 2 commits into
RobLoach:masterfrom
AbubakrBardien:format-fixes
Oct 26, 2026
Merged

penggrin12 merged 2 commits into
RobLoach:masterfrom
AbubakrBardien:format-fixes

Conversation

@AbubakrBardien

Copy link
Copy Markdown
Contributor

Applied the '.clang-format' rules to 'Vector2.hpp', 'Vector3.hpp' and 'Vector4.hpp'.
I also added // clang-format off and // clang-format on lines to a code block that appears intentionally formatted that way for readability.

@penggrin12

Copy link
Copy Markdown
Collaborator

The .clang-format seems to disagree with cpplint.

@AbubakrBardien

Copy link
Copy Markdown
Contributor Author

Hi @penggrin12, thanks for pointing that out. It looks like .clang-format and CPPLINT.cfg are out of sync. Which file needs to be updated?

@penggrin12

Copy link
Copy Markdown
Collaborator

Hi @penggrin12, thanks for pointing that out. It looks like .clang-format and CPPLINT.cfg are out of sync. Which file needs to be updated?

I'm not entirely sure. Probably .clang-format, though. The readme states that cpplint is used.

@RobLoach

Copy link
Copy Markdown
Owner

While both are in there, we could retire one if it makes things easier. cpplint just lints the code, while clang-format formats it. Optimally both would be supported, and work at the same time.

@AbubakrBardien

Copy link
Copy Markdown
Contributor Author

I’ve updated .clang-format so it no longer conflicts with cpplint. If you’d like, I can run clang-format over the rest of the codebase in a separate PR.

@penggrin12

Copy link
Copy Markdown
Collaborator

I’ve updated .clang-format so it no longer conflicts with cpplint. If you’d like, I can run clang-format over the rest of the codebase in a separate PR.

Sounds good.

@penggrin12
penggrin12 merged commit e85a167 into RobLoach:master Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants