fix: verify proxy dispatch tickets - #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DirectoryClientso ticket, fallback, and validation semantics cannot driftIICP_ROUTE_DISCOVERY_MODE=legacy; automatic fallback occurs only when a directory lacks ticket supportSecurity boundary
Invalid tickets, invalid directory keys, policy-binding mismatches, and deterministic ticket refusals do not downgrade to route-bearing discovery. The change does not alter the wire protocol or the behavior of the core
IicpClientticket path.Evidence
uv run --locked --extra dev ruff check src tests scriptsuv run --locked --extra dev pytest -q— 1156 passed, 2 skippeduv run --locked --extra dev python scripts/check_mypy_baseline.py— 74/74 existing findings, no regressionuv run --locked --extra dev python scripts/run_sdk_quality.py --output /tmp/iicp-python-0.7.103-ticket-verification-quality.json— Python 3.11/3.12/3.13, 75.47% coverage, dependency audit, locked build and clean install passedSentrux is not configured in this standalone repository:
sentrux . gatestopped because.sentrux/baseline.jsondoes not exist. No baseline was created or replaced.Relates to RobLe3/iicp.network#612.