Add stable window reference - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a stable, name-independent way to retrieve the “current” root WPF window for a DSL control context, and updates the ImageViewer example and documentation to prefer that approach over relying on a specific registered window name.
Changes:
- Adds
Get-WPFWindow(exported) to resolve the root window from$this/ active context / explicit-ContextId. - Registers the root window into each context under the reserved name
__WPFWindowfrom bothWindowandApp. - Adds Pester coverage for
Get-WPFWindowand updates docs + ImageViewer example usages accordingly.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/WPF/WPF.psd1 | Exports the new Get-WPFWindow helper. |
| src/modules/WPF/Public/Helpers/Get-WPFWindow.ps1 | Implements context-based root window resolution. |
| src/modules/WPF/Public/DSL/Window.ps1 | Registers the root window as __WPFWindow in the context table. |
| src/modules/WPF/Public/DSL/App.ps1 | Registers the root window as __WPFWindow in the context table for app shells. |
| src/modules/WPF/Tests/Get-WPFWindow.Tests.ps1 | Adds tests for root-window resolution across contexts and error cases. |
| src/modules/WPF/Examples/ImageViewer/ImageViewer.DSL.ps1 | Uses Get-WPFWindow / $this instead of Reference 'Window' for root window access. |
| src/modules/WPF/Docs/KeywordReference.md | Documents Get-WPFWindow and updates Reference examples to prefer it for root-window access. |
Comment on lines
+23
to
+26
| $ScopeObject = $PSCmdlet.GetVariableValue('this') | ||
| if ($ScopeObject -is [System.Windows.Window]) { | ||
| return $ScopeObject | ||
| } |
| ``` | ||
|
|
||
| ```powershell | ||
| $Window = Get-WPFWindow -ContextId $Window._WPFContextId |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.