Skip to content

Add Admin_Resource on Admin controllers + Add escaper on templates + Add bind on fetchRow to avoid risk of SQL Injection - #49

Open
bretin wants to merge 1 commit into
Riskified:masterfrom
bretin:security-escaper-acl-injection
Open

Add Admin_Resource on Admin controllers + Add escaper on templates + Add bind on fetchRow to avoid risk of SQL Injection#49
bretin wants to merge 1 commit into
Riskified:masterfrom
bretin:security-escaper-acl-injection

Conversation

@bretin

@bretin bretin commented Jan 6, 2023

Copy link
Copy Markdown

During a technical assessment, I noticed a few security issues:

  • The admin controllers have no admin_resource, we added sales_order ACL since it's on the order grid but it could be a custom ACL
  • A direct SQL query has been adjust to use a binding variable instead of of the direct use in order to avoid risk of SQL injection
  • Template has been adjust to use escapers

…Add bind on fetchRow to avoid risk of SQL Injection
@Daniel-Shai

Copy link
Copy Markdown
Contributor

Hi @wkaminsk , can you please take a look? It's a suggestion from SAQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants