feat(soroban-footprint-diff): compare simulation footprint access modes offline - #494
Merged
Merged
Conversation
|
@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
contract() on a contractData LedgerKey returns an ScAddress union
(account or contract), not raw bytes; calling .toString("hex")
directly on it doesn't type-check and wasn't decoding anything
meaningful. Branch on the address kind and take the actual bytes
(contractId() or accountId().ed25519()) before hex-encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an offline Soroban Footprint Difference Inspector that compares two pasted simulation-result JSON payloads.
Files
Entire slice under
features/soroban-footprint-diff/(35 files,networks: [],offline: true).Out of scope
Test plan
npm run verify:features -- soroban-footprint-diffnpm test -- --run features/soroban-footprint-diffCloses #472