feat(signature-hint-auditor): map envelope signature hints to public candidates - #490
Merged
Merged
Conversation
|
@chainsmt Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #467
Summary
Adds an offline Transaction Signature Hint Auditor under
features/signature-hint-auditor/. Paste a transaction envelope XDR, optionally provide publicG…signer candidates, and see every decorated signature’s four-byte hint mapped to zero/one/many candidates — without treating a hint match as cryptographic verification.Motivation
Envelope XDR already carries decorated signature hints, but operators often confuse “hint matches this pubkey” with “signature verified.” Four bytes collide. Fee-bump envelopes also mix outer fee-source signatures with inner transaction signatures. This tool separates groups and labels matches honestly.
What this PR does
@stellar/stellar-sdk— no Horizon / no network (msw/handlers.tsis empty).lib/decorated-signatures.ts).lib/signer-hints.ts.lib/hint-candidates.ts+CollisionNotice).SignatureRows).S…) on prefix alone in both envelope and signer fields and remounts the form so seeds do not linger in the textarea. Input stays memory-only.empty_xdr,invalid_xdr,invalid_public_signer,unsupported_envelope,too_many_signers.Architecture notes
features/signature-hint-auditor/.fee-bump-inspectorhint listing, but this slice is independent.Acceptance criteria coverage
Out of scope
Test plan
npm run verify:features -- signature-hint-auditor(35 files)npm test -- features/signature-hint-auditor(73 tests)S…seed → refused and cleared